Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500268

Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

Show all headers | View raw

On Thu, Oct 13, 2016 at 10:09:09AM +0200, Stefan Wahren wrote:
> 
> > Stefan Wahren <stefan.wahren@i2se.com> hat am 26. September 2016 um 13:07
> > geschrieben:
> > 
> > 
> > The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces:
> > UART and SPI. This patch series adds the missing support for UART.
> > 
> > This driver based on the Qualcomm code [1], but contains some changes:
> > * use random MAC address per default
> > * use net_device_stats from device
> > * share frame decoding between SPI and UART driver
> > * improve error handling
> > * reimplement tty_wakeup with work queue (based on slcan)
> > 
> > The patches 1 - 3 are just for clean up and are not related to
> > the UART support. Patches 4 - 7 prepare the existing QCA7000
> > code for UART support. The last patch contains the new driver.
> > 
> > In order to test the driver a modified slattach in userspace is also
> > required. A prepared busybox (includes slattach) can be found here [2].
> > 
> > The code itself has been tested on a Freescale i.MX28 board.
> > 
> > Changes in v2:
> >   * fix build issue by using netif_trans_update() and dev_trans_start()
> > 
> > [1] - https://github.com/IoE/qca7000
> > [2] - https://github.com/lategoodbye/busybox/commits/qca7k_support_1_24
> > 
> 
> Gently ping, since i didn't receive any comment for this version.

Wait, this is an RFC, hah, I don't ever review those as obviously you
don't think well enough of it to be proposing this for inclusion :)

Fix up what you think needs to be done and resend it "for real" and it
will enter my review queue.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:10 +0200
  [PATCH RFC v2 net-next 1/8] net: qualcomm: remove unnecessary includes Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:10 +0200
  [PATCH RFC v2 net-next 6/8] net: qualcomm: prepare frame decoding for UART driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:10 +0200
  [PATCH RFC v2 net-next 7/8] net: qualcomm: make qca_common a separate kernel module Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:10 +0200
  [PATCH RFC v2 net-next 8/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:10 +0200
  [PATCH RFC v2 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:10 +0200
  [PATCH RFC v2 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:20 +0200
  [PATCH RFC v2 net-next 5/8] net: qualcomm: move MTU handling to qca_common Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:20 +0200
  [PATCH RFC v2 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-26 13:20 +0200
  Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART  driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-13 10:20 +0200
  Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART  driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-10-13 10:20 +0200
    Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART  driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-13 15:20 +0200

csiph-web