Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure

From	Zefan Li <lizefan@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure
Date	2016-10-13 11:00 +0200
Message-ID	<srK1Q-1cz-9@gated-at.bofh.it> (permalink)
References	<srqZb-4nM-3@gated-at.bofh.it> <srr8T-4rr-49@gated-at.bofh.it> <srriz-4vs-57@gated-at.bofh.it> <srEpr-5zA-13@gated-at.bofh.it> <srJp7-YE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/10/13 16:11, Paul Bolle wrote:
> On Thu, 2016-10-13 at 10:52 +0800, Zefan Li wrote:
>> On 2016/10/12 20:52, Paul Bolle wrote:
>>> There has been a follow up for this fix. I'll have to dive into my
>>> archive to see why that was needed.
>>>
>>> It was complicated, because there has been a short period in which this
>>> fix was correct. Something like that, I'm speaking from memory.
>>> (Perhaps Tilman's memory is less imperfect.)
>>>
>>> I'll try get back to this shortly (in a day or so).
>>>
>>
>> Thanks for looking into this.
> 
> So what I think you also need _on top of_ this patch:
> - commit 8aeb3c3d655e ("ser_gigaset: remove unnecessary kfree() calls
> from release method"), for context changes; and
> - commit 8d2c3ab44456 ("ser_gigaset: use container_of() instead of
> detour"), the proper fix.
> 
> I could not get v3.4 to build _at all_ on my current Fedora 24 machine.
> (v3.4 was probably released when Fedora 16 was still shiny and new.)
> Lack of coffee? So I've only visually inspected these three commits on
> top of v3.4.112. Is that acceptable to you?
> 

Yeah, I'll take it from here. Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure lizf@kernel.org - 2016-10-12 14:50 +0200
  Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform  device structure Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 15:00 +0200
    Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform  device structure Zefan Li <lizefan@huawei.com> - 2016-10-13 05:00 +0200
      Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform  device structure Paul Bolle <pebolle@tiscali.nl> - 2016-10-13 10:20 +0200
        Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform  device structure Zefan Li <lizefan@huawei.com> - 2016-10-13 11:00 +0200

csiph-web