Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500007
| From | Zefan Li <lizefan@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure |
| Date | 2016-10-13 05:00 +0200 |
| Message-ID | <srEpr-5zA-13@gated-at.bofh.it> (permalink) |
| References | <srqZb-4nM-3@gated-at.bofh.it> <srr8T-4rr-49@gated-at.bofh.it> <srriz-4vs-57@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/10/12 20:52, Paul Bolle wrote:
> Zefan Li,
>
> On Wed, 2016-10-12 at 20:33 +0800, lizf@kernel.org wrote:
>> When shutting down the device, the struct ser_cardstate must not be
>> kfree()d immediately after the call to platform_device_unregister()
>> since the embedded struct platform_device is still in use.
>> Move the kfree() call to the release method instead.
>>
>> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
>> Fixes: 2869b23e4b95 ("drivers/isdn/gigaset: new M101 driver (v2)")
>> Reported-by: Sasha Levin <sasha.levin@oracle.com>
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> Signed-off-by: Zefan Li <lizefan@huawei.com>
>
> There has been a follow up for this fix. I'll have to dive into my
> archive to see why that was needed.
>
> It was complicated, because there has been a short period in which this
> fix was correct. Something like that, I'm speaking from memory.
> (Perhaps Tilman's memory is less imperfect.)
>
> I'll try get back to this shortly (in a day or so).
>
Thanks for looking into this.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure lizf@kernel.org - 2016-10-12 14:50 +0200
Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 15:00 +0200
Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure Zefan Li <lizefan@huawei.com> - 2016-10-13 05:00 +0200
Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure Paul Bolle <pebolle@tiscali.nl> - 2016-10-13 10:20 +0200
Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure Zefan Li <lizefan@huawei.com> - 2016-10-13 11:00 +0200
csiph-web