Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

From	Cyrill Gorcunov <gorcunov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets
Date	2016-10-13 09:20 +0200
Message-ID	<srIt4-oQ-3@gated-at.bofh.it> (permalink)
References	<spdML-79a-93@gated-at.bofh.it> <srkKb-61-19@gated-at.bofh.it> <srlGa-Ku-15@gated-at.bofh.it> <srD0m-4pp-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote:
> From: Cyrill Gorcunov <gorcunov@gmail.com>
> Date: Wed, 12 Oct 2016 09:53:29 +0300
> 
> > I can't rename the field, neither a can use union.
> 
> Remind me again what is wrong with using an anonymous union?

Anon union would be a preferred but Eric pointed me that even
though it might cause problems (https://patchwork.kernel.org/patch/9353365/)

 | Note that some programs could fail to compile with the added union
 | anyway.
 |
 | Some gcc versions are unable to compile a static init with an union
 |
 | struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, };
 |
 | When I cooked my recent fq commit I simply removed a pad and replaced
 | it :
 |
 | git show fefa569a9d4bc4 -- include

Thread

[PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-06 12:10 +0200
  Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets David Miller <davem@davemloft.net> - 2016-10-12 08:00 +0200
    Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-12 09:00 +0200
      Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets David Miller <davem@davemloft.net> - 2016-10-13 03:30 +0200
        Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-13 09:20 +0200
          Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets David Ahern <dsa@cumulusnetworks.com> - 2016-10-13 17:50 +0200
            Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-13 18:20 +0200

csiph-web