Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1499380

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

Show all headers | View raw

On Wed, Oct 12, 2016 at 01:50:22AM -0400, David Miller wrote:
> 
> Macros that look like function calls and are also lvalues tend to be
> troublesome.
> 
> I know what you're trying to achieve, you want a named way to access
> this so that the intent and semantics are clear.
> 
> But I'd rather you do something that provides a way by which normal
> struct member accesses do the job, and your earlier patches achieved
> this.

I can't rename the field, neither a can use union. The only acceptable
option I think is introduce inet_diag_v3 structure, which of course
will require the mode wide patching. If there no objections I could
try to implement it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-06 12:10 +0200
  Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets David Miller <davem@davemloft.net> - 2016-10-12 08:00 +0200
    Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-12 09:00 +0200
      Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets David Miller <davem@davemloft.net> - 2016-10-13 03:30 +0200

csiph-web