Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499982
| From | Lorenzo Stoakes <lstoakes@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags |
| Date | 2016-10-13 02:30 +0200 |
| Message-ID | <srC4h-3JZ-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
This patch series adjusts functions in the get_user_pages* family such that desired FOLL_* flags are passed as an argument rather than implied by flags. The purpose of this change is to make the use of FOLL_FORCE explicit so it is easier to grep for and clearer to callers that this flag is being used. The use of FOLL_FORCE is an issue as it overrides missing VM_READ/VM_WRITE flags for the VMA whose pages we are reading from/writing to, which can result in surprising behaviour. The patch series came out of the discussion around commit 38e0885, which addressed a BUG_ON() being triggered when a page was faulted in with PROT_NONE set but having been overridden by FOLL_FORCE. do_numa_page() was run on the assumption the page _must_ be one marked for NUMA node migration as an actual PROT_NONE page would have been dealt with prior to this code path, however FOLL_FORCE introduced a situation where this assumption did not hold. See https://marc.info/?l=linux-mm&m=147585445805166 for the patch proposal. Lorenzo Stoakes (10): mm: remove write/force parameters from __get_user_pages_locked() mm: remove write/force parameters from __get_user_pages_unlocked() mm: replace get_user_pages_unlocked() write/force parameters with gup_flags mm: replace get_user_pages_locked() write/force parameters with gup_flags mm: replace get_vaddr_frames() write/force parameters with gup_flags mm: replace get_user_pages() write/force parameters with gup_flags mm: replace get_user_pages_remote() write/force parameters with gup_flags mm: replace __access_remote_vm() write parameter with gup_flags mm: replace access_remote_vm() write parameter with gup_flags mm: replace access_process_vm() write parameter with gup_flags arch/alpha/kernel/ptrace.c | 9 ++-- arch/blackfin/kernel/ptrace.c | 5 ++- arch/cris/arch-v32/drivers/cryptocop.c | 4 +- arch/cris/arch-v32/kernel/ptrace.c | 4 +- arch/ia64/kernel/err_inject.c | 2 +- arch/ia64/kernel/ptrace.c | 14 +++--- arch/m32r/kernel/ptrace.c | 15 ++++--- arch/mips/kernel/ptrace32.c | 5 ++- arch/mips/mm/gup.c | 2 +- arch/powerpc/kernel/ptrace32.c | 5 ++- arch/s390/mm/gup.c | 3 +- arch/score/kernel/ptrace.c | 10 +++-- arch/sh/mm/gup.c | 3 +- arch/sparc/kernel/ptrace_64.c | 24 +++++++---- arch/sparc/mm/gup.c | 3 +- arch/x86/kernel/step.c | 3 +- arch/x86/mm/gup.c | 2 +- arch/x86/mm/mpx.c | 5 +-- arch/x86/um/ptrace_32.c | 3 +- arch/x86/um/ptrace_64.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ++- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 ++- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +- drivers/gpu/drm/i915/i915_gem_userptr.c | 6 ++- drivers/gpu/drm/radeon/radeon_ttm.c | 3 +- drivers/gpu/drm/via/via_dmablit.c | 4 +- drivers/infiniband/core/umem.c | 6 ++- drivers/infiniband/core/umem_odp.c | 7 ++- drivers/infiniband/hw/mthca/mthca_memfree.c | 2 +- drivers/infiniband/hw/qib/qib_user_pages.c | 3 +- drivers/infiniband/hw/usnic/usnic_uiom.c | 5 ++- drivers/media/pci/ivtv/ivtv-udma.c | 4 +- drivers/media/pci/ivtv/ivtv-yuv.c | 5 ++- drivers/media/platform/omap/omap_vout.c | 2 +- drivers/media/v4l2-core/videobuf-dma-sg.c | 7 ++- drivers/media/v4l2-core/videobuf2-memops.c | 6 ++- drivers/misc/mic/scif/scif_rma.c | 3 +- drivers/misc/sgi-gru/grufault.c | 2 +- drivers/platform/goldfish/goldfish_pipe.c | 3 +- drivers/rapidio/devices/rio_mport_cdev.c | 3 +- drivers/scsi/st.c | 5 +-- .../interface/vchiq_arm/vchiq_2835_arm.c | 3 +- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +- drivers/video/fbdev/pvr2fb.c | 4 +- drivers/virt/fsl_hypervisor.c | 4 +- fs/exec.c | 9 +++- fs/proc/base.c | 19 +++++--- include/linux/mm.h | 18 ++++---- kernel/events/uprobes.c | 6 ++- kernel/ptrace.c | 16 ++++--- mm/frame_vector.c | 9 ++-- mm/gup.c | 50 ++++++++++------------ mm/memory.c | 16 ++++--- mm/mempolicy.c | 2 +- mm/nommu.c | 38 +++++++--------- mm/process_vm_access.c | 7 ++- mm/util.c | 8 ++-- net/ceph/pagevec.c | 2 +- security/tomoyo/domain.c | 2 +- virt/kvm/async_pf.c | 3 +- virt/kvm/kvm_main.c | 11 +++-- 61 files changed, 260 insertions(+), 187 deletions(-)
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 02:30 +0200
[PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked() Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 02:30 +0200
Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked() Paolo Bonzini <pbonzini@redhat.com> - 2016-10-13 09:00 +0200
Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked() Jan Kara <jack@suse.cz> - 2016-10-18 14:50 +0200
[PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 02:30 +0200
Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-18 15:00 +0200
[PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 05:00 +0200
Re: [PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-19 11:10 +0200
[PATCH 09/10] mm: replace access_remote_vm() write parameter with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 06:10 +0200
[PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 06:20 +0200
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Michal Hocko <mhocko@kernel.org> - 2016-10-19 11:10 +0200
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-19 16:50 +0200
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Michal Hocko <mhocko@kernel.org> - 2016-10-19 18:10 +0200
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-19 16:30 +0200
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Jan Kara <jack@suse.cz> - 2016-10-19 16:50 +0200
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags Michal Hocko <mhocko@kernel.org> - 2016-10-19 18:30 +0200
[PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 06:20 +0200
Re: [PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-19 18:30 +0200
[PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 06:40 +0200
Re: [PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags Jesper Nilsson <jesper.nilsson@axis.com> - 2016-10-17 11:30 +0200
[PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 06:40 +0200
Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags Jesper Nilsson <jesper.nilsson@axis.com> - 2016-10-17 11:30 +0200
Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-19 11:10 +0200
[PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-13 08:10 +0200
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-18 15:00 +0200
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-18 16:00 +0200
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-19 09:40 +0200
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-19 17:30 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Michal Hocko <mhocko@kernel.org> - 2016-10-18 17:40 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Michal Hocko <mhocko@kernel.org> - 2016-10-19 16:20 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Dave Hansen <dave.hansen@linux.intel.com> - 2016-10-19 19:00 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Michal Hocko <mhocko@kernel.org> - 2016-10-19 19:10 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Dave Hansen <dave.hansen@linux.intel.com> - 2016-10-19 19:30 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Michal Hocko <mhocko@kernel.org> - 2016-10-20 21:30 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-19 18:20 +0200
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-26 11:00 +0200
csiph-web