Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags
Date	2016-10-18 15:00 +0200
Message-ID	<stC9P-1M3-27@gated-at.bofh.it> (permalink)
References	<srC4h-3JZ-3@gated-at.bofh.it> <srC4i-3JZ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 13-10-16 01:20:13, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from get_user_pages_unlocked()
> and replaces them with a gup_flags parameter to make the use of FOLL_FORCE
> explicit in callers as use of this flag can result in surprising behaviour (and
> hence bugs) within the mm subsystem.
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force  parameters with gup_flags Jan Kara <jack@suse.cz> - 2016-10-18 15:00 +0200

csiph-web