Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1499078

[PATCH 37/68] perf c2c report: Add 'cpucnt' sort key

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 37/68] perf c2c report: Add 'cpucnt' sort key
Date 2016-10-11 19:50 +0200
Message-ID <sr9lD-1cs-5@gated-at.bofh.it> (permalink)
References <sr9bX-195-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jiri Olsa <jolsa@kernel.org>

It is to be displayed in the single cacheline output:

  cpucnt

It displays number of distinct cpus that hit cacheline.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-ib2kdwam52fby9u2k3ij6lhm@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-c2c.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 043344a720bf..2a1e883580a1 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1015,6 +1015,20 @@ MEAN_ENTRY(mean_rmt_entry,  rmt_hitm);
 MEAN_ENTRY(mean_lcl_entry,  lcl_hitm);
 MEAN_ENTRY(mean_load_entry, load);
 
+static int
+cpucnt_entry(struct perf_hpp_fmt *fmt __maybe_unused, struct perf_hpp *hpp,
+	     struct hist_entry *he)
+{
+	struct c2c_hist_entry *c2c_he;
+	int width = c2c_width(fmt, hpp, he->hists);
+	char buf[10];
+
+	c2c_he = container_of(he, struct c2c_hist_entry, he);
+
+	scnprintf(buf, 10, "%d", bitmap_weight(c2c_he->cpuset, c2c.cpus_cnt));
+	return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
+}
+
 #define HEADER_LOW(__h)			\
 	{				\
 		.line[1] = {		\
@@ -1341,6 +1355,14 @@ static struct c2c_dimension dim_mean_load = {
 	.width		= 8,
 };
 
+static struct c2c_dimension dim_cpucnt = {
+	.header		= HEADER_BOTH("cpu", "cnt"),
+	.name		= "cpucnt",
+	.cmp		= empty_cmp,
+	.entry		= cpucnt_entry,
+	.width		= 8,
+};
+
 static struct c2c_dimension *dimensions[] = {
 	&dim_dcacheline,
 	&dim_offset,
@@ -1378,6 +1400,7 @@ static struct c2c_dimension *dimensions[] = {
 	&dim_mean_rmt,
 	&dim_mean_lcl,
 	&dim_mean_load,
+	&dim_cpucnt,
 	NULL,
 };
 
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL 00/68] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:40 +0200
  [PATCH 42/68] perf c2c report: Add main TUI browser Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:40 +0200
  [PATCH 61/68] tools lib: Add for_each_clear_bit macro Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 37/68] perf c2c report: Add 'cpucnt' sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 11/68] perf c2c: Add report subcommand Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 48/68] perf c2c report: Limit the cachelines table entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 12/68] perf c2c report: Add dimension support Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 57/68] tools lib traceevent: Add install_headers target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 10/68] perf c2c: Add record subcommand Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 38/68] perf c2c report: Add src line sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 08/68] perf c2c: Introduce c2c_add_stats function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 27/68] perf c2c report: Add total record sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 60/68] tools lib traceevent: Add version for traceevent shared object Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 39/68] perf c2c report: Setup number of header lines for hists Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 06/68] perf tools: Sync copy of x86's syscall table Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 16/68] perf c2c report: Add cacheline hists processing Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 31/68] perf c2c report: Add dram related sort keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 15/68] perf c2c report: Add sample processing Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 34/68] perf c2c report: Add 'symbol' and 'dso' sort keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 23/68] perf c2c report: Add stores related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 20/68] perf c2c report: Add 'offset' dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 01/68] perf list: Add support for listing only json events Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 03/68] perf intel-pt/bts: Tidy instruction buffer size usage Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 05/68] perf top: Fix refreshing hierarchy entries on TUI Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 28/68] perf c2c report: Add total loads sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 25/68] perf c2c report: Add llc and remote loads related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 24/68] perf c2c report: Add loads related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 14/68] perf c2c report: Fallback to standard dimensions Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 18/68] perf c2c report: Add header macros Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 13/68] perf c2c report: Add sort_entry dimension support Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 21/68] perf c2c report: Add 'iaddr' dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 32/68] perf c2c report: Add 'pid' sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 22/68] perf c2c report: Add hitm related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 04/68] perf intel-pt/bts: Report instruction bytes and length in sample Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 07/68] perf c2c: Introduce c2c_decode_stats function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200

csiph-web