Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1499082

[PATCH 11/68] perf c2c: Add report subcommand

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 11/68] perf c2c: Add report subcommand
Date 2016-10-11 19:50 +0200
Message-ID <sr9lD-1cs-21@gated-at.bofh.it> (permalink)
References <sr9bX-195-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jiri Olsa <jolsa@kernel.org>

Adding c2c report subcommand. It reads the perf.data and displays shared
data analysis.

This patch adds report basic wirings. It gets fully implemented in
following patches.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1474558645-19956-13-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-c2c.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 65 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 58924c67f818..3fac3a294bdd 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -5,12 +5,74 @@
 #include "builtin.h"
 #include <subcmd/parse-options.h>
 #include "mem-events.h"
+#include "session.h"
+#include "hist.h"
+#include "tool.h"
+#include "data.h"
+
+struct perf_c2c {
+	struct perf_tool tool;
+};
+
+static struct perf_c2c c2c;
 
 static const char * const c2c_usage[] = {
-	"perf c2c",
+	"perf c2c {record|report}",
 	NULL
 };
 
+static const char * const __usage_report[] = {
+	"perf c2c report",
+	NULL
+};
+
+static const char * const *report_c2c_usage = __usage_report;
+
+static int perf_c2c__report(int argc, const char **argv)
+{
+	struct perf_session *session;
+	struct perf_data_file file = {
+		.mode = PERF_DATA_MODE_READ,
+	};
+	const struct option c2c_options[] = {
+	OPT_STRING('k', "vmlinux", &symbol_conf.vmlinux_name,
+		   "file", "vmlinux pathname"),
+	OPT_INCR('v', "verbose", &verbose,
+		 "be more verbose (show counter open errors, etc)"),
+	OPT_STRING('i', "input", &input_name, "file",
+		   "the input file to process"),
+	OPT_END()
+	};
+	int err = 0;
+
+	argc = parse_options(argc, argv, c2c_options, report_c2c_usage,
+			     PARSE_OPT_STOP_AT_NON_OPTION);
+	if (!argc)
+		usage_with_options(report_c2c_usage, c2c_options);
+
+	file.path = input_name;
+
+	session = perf_session__new(&file, 0, &c2c.tool);
+	if (session == NULL) {
+		pr_debug("No memory for session\n");
+		goto out;
+	}
+
+	if (symbol__init(&session->header.env) < 0)
+		goto out_session;
+
+	/* No pipe support at the moment. */
+	if (perf_data_file__is_pipe(session->file)) {
+		pr_debug("No pipe support at the moment.\n");
+		goto out_session;
+	}
+
+out_session:
+	perf_session__delete(session);
+out:
+	return err;
+}
+
 static int parse_record_events(const struct option *opt __maybe_unused,
 			       const char *str, int unset __maybe_unused)
 {
@@ -129,6 +191,8 @@ int cmd_c2c(int argc, const char **argv, const char *prefix __maybe_unused)
 
 	if (!strncmp(argv[0], "rec", 3)) {
 		return perf_c2c__record(argc, argv);
+	} else if (!strncmp(argv[0], "rep", 3)) {
+		return perf_c2c__report(argc, argv);
 	} else {
 		usage_with_options(c2c_usage, c2c_options);
 	}
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL 00/68] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:40 +0200
  [PATCH 42/68] perf c2c report: Add main TUI browser Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:40 +0200
  [PATCH 61/68] tools lib: Add for_each_clear_bit macro Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 37/68] perf c2c report: Add 'cpucnt' sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 11/68] perf c2c: Add report subcommand Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 48/68] perf c2c report: Limit the cachelines table entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 19:50 +0200
  [PATCH 12/68] perf c2c report: Add dimension support Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 57/68] tools lib traceevent: Add install_headers target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 10/68] perf c2c: Add record subcommand Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 38/68] perf c2c report: Add src line sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 08/68] perf c2c: Introduce c2c_add_stats function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 27/68] perf c2c report: Add total record sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 60/68] tools lib traceevent: Add version for traceevent shared object Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 39/68] perf c2c report: Setup number of header lines for hists Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 06/68] perf tools: Sync copy of x86's syscall table Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 16/68] perf c2c report: Add cacheline hists processing Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 31/68] perf c2c report: Add dram related sort keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:00 +0200
  [PATCH 15/68] perf c2c report: Add sample processing Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 34/68] perf c2c report: Add 'symbol' and 'dso' sort keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 23/68] perf c2c report: Add stores related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 20/68] perf c2c report: Add 'offset' dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 01/68] perf list: Add support for listing only json events Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 03/68] perf intel-pt/bts: Tidy instruction buffer size usage Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 05/68] perf top: Fix refreshing hierarchy entries on TUI Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 28/68] perf c2c report: Add total loads sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 25/68] perf c2c report: Add llc and remote loads related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 24/68] perf c2c report: Add loads related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 14/68] perf c2c report: Fallback to standard dimensions Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 18/68] perf c2c report: Add header macros Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 13/68] perf c2c report: Add sort_entry dimension support Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 21/68] perf c2c report: Add 'iaddr' dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 32/68] perf c2c report: Add 'pid' sort key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 22/68] perf c2c report: Add hitm related dimension keys Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 04/68] perf intel-pt/bts: Report instruction bytes and length in sample Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200
  [PATCH 07/68] perf c2c: Introduce c2c_decode_stats function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-11 20:10 +0200

csiph-web