Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499002
| From | Andy Whitcroft <apw@canonical.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/1 V2] dm raid: fix compat_features validation |
| Date | 2016-10-11 18:30 +0200 |
| Message-ID | <sr86d-wM-1@gated-at.bofh.it> (permalink) |
| References | <sr6nM-7Uu-35@gated-at.bofh.it> <sr6QO-8jN-13@gated-at.bofh.it> <sr7tw-4W-13@gated-at.bofh.it> <sr7tw-4W-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From a30fba068e41214cb0ffcb14e68722482765e0c9 Mon Sep 17 00:00:00 2001
From: Andy Whitcroft <apw@canonical.com>
Date: Tue, 11 Oct 2016 15:16:57 +0100
In ecbfb9f118bce4 ("dm raid: add raid level takeover support") a new
compatible feature flag was added. Validation for these compat_features
was added but this only passes for new raid mappings with this feature
flag. This causes previously created raid mappings to be failed at
import.
Check compat_features for the only valid combination.
Fixes: ecbfb9f118bce4 ("dm raid: add raid level takeover support")
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
drivers/md/dm-raid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
V2: simplify checks as per maintainer.
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 8abde6b..2a39700 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2258,7 +2258,8 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev)
if (!mddev->events && super_init_validation(rs, rdev))
return -EINVAL;
- if (le32_to_cpu(sb->compat_features) != FEATURE_FLAG_SUPPORTS_V190) {
+ if (le32_to_cpu(sb->compat_features) &&
+ le32_to_cpu(sb->compat_features) != FEATURE_FLAG_SUPPORTS_V190) {
rs->ti->error = "Unable to assemble array: Unknown flag(s) in compatible feature flags";
return -EINVAL;
}
--
2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/1] dm raid: fix compat_features validation Andy Whitcroft <apw@canonical.com> - 2016-10-11 16:40 +0200
Re: [PATCH 1/1] dm raid: fix compat_features validation Mike Snitzer <snitzer@redhat.com> - 2016-10-11 16:50 +0200
Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation Heinz Mauelshagen <heinzm@redhat.com> - 2016-10-11 17:10 +0200
Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation Heinz Mauelshagen <heinzm@redhat.com> - 2016-10-11 17:50 +0200
[PATCH 1/1 V2] dm raid: fix compat_features validation Andy Whitcroft <apw@canonical.com> - 2016-10-11 18:30 +0200
Re: [PATCH 1/1 V2] dm raid: fix compat_features validation Heinz Mauelshagen <heinzm@redhat.com> - 2016-10-11 19:00 +0200
Re: [PATCH 1/1] dm raid: fix compat_features validation Mike Snitzer <snitzer@redhat.com> - 2016-10-11 20:00 +0200
Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation Andy Whitcroft <apw@canonical.com> - 2016-10-11 18:00 +0200
csiph-web