Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1498995
| From | Andy Whitcroft <apw@canonical.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation |
| Date | 2016-10-11 18:00 +0200 |
| Message-ID | <sr7tw-4W-13@gated-at.bofh.it> (permalink) |
| References | <sr6nM-7Uu-35@gated-at.bofh.it> <sr6QO-8jN-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote:
>
> Andy,
>
> good catch.
>
> We should rather check for V190 support only in case any
> compat feature flags are actually set.
>
> {
> + if (le32_to_cpu(sb->compat_features) &&
> + le32_to_cpu(sb->compat_features) != FEATURE_FLAG_SUPPORTS_V190)
> {
> rs->ti->error = "Unable to assemble array: Unknown flag(s)
> in compatible feature flags";
> return -EINVAL;
> }
If the feature flags are single bit combinations then I believe the
below does check exactly that. Checking for no 1s outside of the
expected features, caring not for the value of the valid bits:
+ if (le32_to_cpu(sb->compat_features) & ~(FEATURE_FLAG_SUPPORTS_V190)) {
with the possibilty to or in additional feature bits as they are added.
-apw
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 1/1] dm raid: fix compat_features validation Andy Whitcroft <apw@canonical.com> - 2016-10-11 16:40 +0200
Re: [PATCH 1/1] dm raid: fix compat_features validation Mike Snitzer <snitzer@redhat.com> - 2016-10-11 16:50 +0200
Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation Heinz Mauelshagen <heinzm@redhat.com> - 2016-10-11 17:10 +0200
Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation Heinz Mauelshagen <heinzm@redhat.com> - 2016-10-11 17:50 +0200
[PATCH 1/1 V2] dm raid: fix compat_features validation Andy Whitcroft <apw@canonical.com> - 2016-10-11 18:30 +0200
Re: [PATCH 1/1 V2] dm raid: fix compat_features validation Heinz Mauelshagen <heinzm@redhat.com> - 2016-10-11 19:00 +0200
Re: [PATCH 1/1] dm raid: fix compat_features validation Mike Snitzer <snitzer@redhat.com> - 2016-10-11 20:00 +0200
Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation Andy Whitcroft <apw@canonical.com> - 2016-10-11 18:00 +0200
csiph-web