Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498091

[PATCH v3 10/12] scsi/ncr5380: Expedite register polling

Show all headers | View raw

Avoid the call to NCR5380_poll_politely2() when possible. The call is
easily short-circuited on the PIO fast path, using the inline wrapper.
This requires that the NCR5380_read macro be made available before
any #include "NCR5380.h" so a few declarations have to be moved too.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
---
 drivers/scsi/NCR5380.h      | 3 +++
 drivers/scsi/arm/cumana_1.c | 4 ++++
 drivers/scsi/atari_scsi.c   | 6 +++---
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/NCR5380.h b/drivers/scsi/NCR5380.h
index 4682baa..b2c560c 100644
--- a/drivers/scsi/NCR5380.h
+++ b/drivers/scsi/NCR5380.h
@@ -310,6 +310,9 @@ static inline int NCR5380_poll_politely(struct NCR5380_hostdata *hostdata,
                                         unsigned int reg, u8 bit, u8 val,
                                         unsigned long wait)
 {
+	if ((NCR5380_read(reg) & bit) == val)
+		return 0;
+
 	return NCR5380_poll_politely2(hostdata, reg, bit, val,
 						reg, bit, val, wait);
 }
diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c
index ae1d4c6..fb7600d 100644
--- a/drivers/scsi/arm/cumana_1.c
+++ b/drivers/scsi/arm/cumana_1.c
@@ -29,6 +29,10 @@
 #define NCR5380_implementation_fields	\
 	unsigned ctrl
 
+struct NCR5380_hostdata;
+static u8 cumanascsi_read(struct NCR5380_hostdata *, unsigned int);
+static void cumanascsi_write(struct NCR5380_hostdata *, unsigned int, u8);
+
 #include "../NCR5380.h"
 
 #define CTRL	0x16fc
diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c
index aed69ac..f77c311 100644
--- a/drivers/scsi/atari_scsi.c
+++ b/drivers/scsi/atari_scsi.c
@@ -57,6 +57,9 @@
 
 #define NCR5380_implementation_fields   /* none */
 
+static u8 (*atari_scsi_reg_read)(unsigned int);
+static void (*atari_scsi_reg_write)(unsigned int, u8);
+
 #define NCR5380_read(reg)               atari_scsi_reg_read(reg)
 #define NCR5380_write(reg, value)       atari_scsi_reg_write(reg, value)
 
@@ -126,9 +129,6 @@ static inline unsigned long SCSI_DMA_GETADR(void)
 
 static void atari_scsi_fetch_restbytes(void);
 
-static u8 (*atari_scsi_reg_read)(unsigned int);
-static void (*atari_scsi_reg_write)(unsigned int, u8);
-
 static unsigned long	atari_dma_residual, atari_dma_startaddr;
 static short		atari_dma_active;
 /* pointer to the dribble buffer */
-- 
2.7.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 07/12] scsi/ncr5380: Store IO ports and addresses in host  private data Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
    Re: [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-10-10 11:20 +0200
      Re: [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Finn Thain <fthain@telegraphics.com.au> - 2016-10-11 01:00 +0200
  [PATCH v3 12/12] scsi/ncr5380: Suppress unhelpful "interrupt without  IRQ bit" message Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 06/12] scsi/ncr5380: Improve hostdata struct member  alignment and cache-ability Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 04/12] scsi/ncr5380: Simplify register polling limit Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 05/12] scsi/ncr5380: Increase register polling limit Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 01/12] scsi/g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio  drivers Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 08/12] scsi/ncr5380: Use correct types for device register  accessors Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
    Re: [PATCH v3 08/12] scsi/ncr5380: Use correct types for device  register accessors Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-10-10 11:20 +0200
  [PATCH v3 09/12] scsi/ncr5380: Pass hostdata pointer to register  polling routines Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200

csiph-web