Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498092

[PATCH v3 12/12] scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message

Show all headers | View raw

If a NCR5380 host instance ends up on a shared interrupt line then
this printk will be a problem. It is already a problem on some Mac
models: when testing mac_scsi on a PowerBook 180 I found that PDMA
transfers (but not PIO transfers) cause the message to be logged.

These spurious interrupts don't appear to come from the DRQ signal from
the 5380. And they don't happen at all on the Mac LC III. A comment in
the NetBSD source code mentions this mystery. Testing seems to show
that we can safely ignore these interrupts.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
---
 drivers/scsi/NCR5380.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 72ac31cd..0c3c7e6 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -995,7 +995,7 @@ static irqreturn_t __maybe_unused NCR5380_intr(int irq, void *dev_id)
 		}
 		handled = 1;
 	} else {
-		shost_printk(KERN_NOTICE, instance, "interrupt without IRQ bit\n");
+		dsprintk(NDEBUG_INTR, instance, "interrupt without IRQ bit\n");
 #ifdef SUN3_SCSI_VME
 		dregs->csr |= CSR_DMA_ENABLE;
 #endif
-- 
2.7.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 07/12] scsi/ncr5380: Store IO ports and addresses in host  private data Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
    Re: [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-10-10 11:20 +0200
      Re: [PATCH v3 10/12] scsi/ncr5380: Expedite register polling Finn Thain <fthain@telegraphics.com.au> - 2016-10-11 01:00 +0200
  [PATCH v3 12/12] scsi/ncr5380: Suppress unhelpful "interrupt without  IRQ bit" message Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 06/12] scsi/ncr5380: Improve hostdata struct member  alignment and cache-ability Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 04/12] scsi/ncr5380: Simplify register polling limit Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 05/12] scsi/ncr5380: Increase register polling limit Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 01/12] scsi/g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio  drivers Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
  [PATCH v3 08/12] scsi/ncr5380: Use correct types for device register  accessors Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200
    Re: [PATCH v3 08/12] scsi/ncr5380: Use correct types for device  register accessors Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-10-10 11:20 +0200
  [PATCH v3 09/12] scsi/ncr5380: Pass hostdata pointer to register  polling routines Finn Thain <fthain@telegraphics.com.au> - 2016-10-10 06:50 +0200

csiph-web