Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1496260
| From | Jörg Otte <jrg.otte@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Problem with VMAP_STACK=y |
| Date | 2016-10-06 10:40 +0200 |
| Message-ID | <spcnF-64l-73@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <soOY1-67p-13@gated-at.bofh.it> <soPho-6eP-11@gated-at.bofh.it> <soQn8-7dj-27@gated-at.bofh.it> <soZgJ-5b4-3@gated-at.bofh.it> <soZA5-5oJ-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2016-10-05 20:55 GMT+02:00 Mauro Carvalho Chehab <mchehab@s-opensource.com>:
> Hi Johannes,
>
> Em Wed, 5 Oct 2016 20:29:45 +0200
> Johannes Stezenbach <js@linuxtv.org> escreveu:
>
>> On Wed, Oct 05, 2016 at 06:04:50AM -0300, Mauro Carvalho Chehab wrote:
>> > static int cinergyt2_frontend_attach(struct dvb_usb_adapter *adap)
>> > {
>> > - char query[] = { CINERGYT2_EP1_GET_FIRMWARE_VERSION };
>> > - char state[3];
>> > + struct dvb_usb_device *d = adap->dev;
>> > + struct cinergyt2_state *st = d->priv;
>> > int ret;
>> >
>> > adap->fe_adap[0].fe = cinergyt2_fe_attach(adap->dev);
>> >
>> > - ret = dvb_usb_generic_rw(adap->dev, query, sizeof(query), state,
>> > - sizeof(state), 0);
>>
>> it seems to miss this:
>>
>> st->data[0] = CINERGYT2_EP1_GET_FIRMWARE_VERSION;
>>
>> > + ret = dvb_usb_generic_rw(d, st->data, 1, st->data, 3, 0);
>> > if (ret < 0) {
>> > deb_rc("cinergyt2_power_ctrl() Failed to retrieve sleep "
>> > "state info\n");
>> > @@ -141,13 +147,14 @@ static int repeatable_keys[] = {
>> > static int cinergyt2_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
>> > {
>> > struct cinergyt2_state *st = d->priv;
>> > - u8 key[5] = {0, 0, 0, 0, 0}, cmd = CINERGYT2_EP1_GET_RC_EVENTS;
>> > int i;
>> >
>> > *state = REMOTE_NO_KEY_PRESSED;
>> >
>> > - dvb_usb_generic_rw(d, &cmd, 1, key, sizeof(key), 0);
>> > - if (key[4] == 0xff) {
>> > + st->data[0] = CINERGYT2_EP1_SLEEP_MODE;
>>
>> should probably be
>>
>> st->data[0] = CINERGYT2_EP1_GET_RC_EVENTS;
>>
>> > +
>> > + dvb_usb_generic_rw(d, st->data, 1, st->data, 5, 0);
>>
>>
>> HTH,
>> Johannes
>
>
> Thanks for the review! Yeah, you're right: both firmware and remote
> controller logic would be broken without the above fixes.
>
> Just sent a version 2 of this patch to the ML with the above fixes.
>
> Regards,
> Mauro
Applied V2 of the patch. Unfortunately no progress.
No video, no error messages.
Jörg
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-04 14:30 +0200
Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-04 15:30 +0200
Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-04 18:20 +0200
Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-05 09:30 +0200
Re: Problem with VMAP_STACK=y Patrick Boettcher <patrick.boettcher@posteo.de> - 2016-10-05 09:40 +0200
Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-05 10:00 +0200
Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-05 11:10 +0200
Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-05 13:30 +0200
Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-05 17:30 +0200
Re: Problem with VMAP_STACK=y Andy Lutomirski <luto@amacapital.net> - 2016-10-05 18:00 +0200
Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-05 18:50 +0200
Re: Problem with VMAP_STACK=y Andy Lutomirski <luto@amacapital.net> - 2016-10-05 19:00 +0200
Re: Problem with VMAP_STACK=y Johannes Stezenbach <js@linuxtv.org> - 2016-10-05 20:40 +0200
Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-05 21:00 +0200
Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-06 10:40 +0200
Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-06 19:20 +0200
Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-07 10:00 +0200
Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-07 13:20 +0200
dvb-usb stack-memory used for URB-buffers (was: Re: Problem with VMAP_STACK=y) Patrick Boettcher <patrick.boettcher@posteo.de> - 2016-10-05 09:50 +0200
csiph-web