Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1497129

Re: Problem with VMAP_STACK=y

From Mauro Carvalho Chehab <mchehab@s-opensource.com>
Newsgroups linux.kernel
Subject Re: Problem with VMAP_STACK=y
Date 2016-10-07 13:20 +0200
Message-ID <spBm2-827-15@gated-at.bofh.it> (permalink)
References (7 earlier) <soZgJ-5b4-3@gated-at.bofh.it> <soZA5-5oJ-17@gated-at.bofh.it> <spcnF-64l-73@gated-at.bofh.it> <spkuR-3vj-15@gated-at.bofh.it> <spyet-5tC-1@gated-at.bofh.it>
Organization Samsung

Show all headers | View raw

Em Fri, 7 Oct 2016 09:52:56 +0200 (CEST)
Jiri Kosina <jikos@kernel.org> escreveu:

> On Thu, 6 Oct 2016, Mauro Carvalho Chehab wrote:
> 
> > I can't see any other obvious error on the conversion. You could try to 
> > enable debug options at DVB core/dvb-usb and/or add some printk's to the 
> > driver and see what's happening.
> 
> Mauro, also please don't forget that there are many more places in 
> drivers/media that still perform DMA on stack, and so have to be fixed for 
> 4.9 (as VMAP_STACK makes that to be immediately visible problem even on 
> x86_64, which it wasn't the case before).

Yes, I'm aware of that. I'm doing the conversion of drivers under dvb-usb,
at:
	https://git.linuxtv.org/mchehab/experimental.git/log/?h=media_dmastack_fixes

I'll be sending the patches to the ML after ready.

I'll then take a look on other USB drivers that use the stack. I guess
the non-USB media drivers are safe from this issue.

Thanks,
Mauro

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-04 14:30 +0200
  Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-04 15:30 +0200
    Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-04 18:20 +0200
      Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-05 09:30 +0200
        Re: Problem with VMAP_STACK=y Patrick Boettcher <patrick.boettcher@posteo.de> - 2016-10-05 09:40 +0200
          Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-05 10:00 +0200
            Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-05 11:10 +0200
              Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-05 13:30 +0200
              Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-05 17:30 +0200
                Re: Problem with VMAP_STACK=y Andy Lutomirski <luto@amacapital.net> - 2016-10-05 18:00 +0200
                Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-05 18:50 +0200
                Re: Problem with VMAP_STACK=y Andy Lutomirski <luto@amacapital.net> - 2016-10-05 19:00 +0200
              Re: Problem with VMAP_STACK=y Johannes Stezenbach <js@linuxtv.org> - 2016-10-05 20:40 +0200
                Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-05 21:00 +0200
                Re: Problem with VMAP_STACK=y Jörg Otte <jrg.otte@gmail.com> - 2016-10-06 10:40 +0200
                Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-06 19:20 +0200
                Re: Problem with VMAP_STACK=y Jiri Kosina <jikos@kernel.org> - 2016-10-07 10:00 +0200
                Re: Problem with VMAP_STACK=y Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-10-07 13:20 +0200
    dvb-usb stack-memory used for URB-buffers (was: Re: Problem with  VMAP_STACK=y) Patrick Boettcher <patrick.boettcher@posteo.de> - 2016-10-05 09:50 +0200

csiph-web