Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

From	Johan Hedberg <johan.hedberg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel
Date	2016-10-06 10:40 +0200
Message-ID	<spcnF-64l-65@gated-at.bofh.it> (permalink)
References	(4 earlier) <soZTs-5Rt-31@gated-at.bofh.it> <sp2HD-89L-19@gated-at.bofh.it> <sp2Rj-8d2-1@gated-at.bofh.it> <spaYx-5fl-13@gated-at.bofh.it> <spaYx-5fl-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Thu, Oct 06, 2016, Joe Perches wrote:
> On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote:
> > I believe you are wrong. bit addressability does not matter, cpu can
> > definitely get the bit values.
> > 
> > u8 foo:1;
> > u8 bar:1;
> > u8 baz:1;
> > 
> > should take 1 byte, where
> > 
> > bool foo, bar, baz;
> > 
> > will take more like 3.
> 
> Definitely true.
> 
> There is only one single bitfield foo here though
> so what you wrote doesn't apply.

What's in the tree is a left-over from times when there were multiple
bit fields in this struct. By the time others were removed and there was
only one left no-one has apparently bothered to update it to a bool or
single u8.

Johan

Thread

[PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-03 11:00 +0200
  Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Marcel Holtmann <marcel@holtmann.org> - 2016-10-05 13:20 +0200
    Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-05 20:00 +0200
      Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-05 21:20 +0200
        Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-05 21:20 +0200
          Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-06 00:20 +0200
            Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 00:30 +0200
              Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-06 09:10 +0200
                Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 09:10 +0200
                Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Johan Hedberg <johan.hedberg@gmail.com> - 2016-10-06 10:40 +0200
          RE: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel David Laight <David.Laight@ACULAB.COM> - 2016-10-06 11:50 +0200
            Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 13:40 +0200
              RE: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel David Laight <David.Laight@ACULAB.COM> - 2016-10-06 15:10 +0200
                Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 17:50 +0200
  [PATCHv2] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-05 23:00 +0200
    Re: [PATCHv2] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Marcel Holtmann <marcel@holtmann.org> - 2016-10-06 00:00 +0200

csiph-web