Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1496008

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed 2016-10-05 10:53:16, Joe Perches wrote:
> On Wed, 2016-10-05 at 13:14 +0200, Marcel Holtmann wrote:
> > Hi Pavel,
> > 
> > > bluetooth.h is not part of user API, so __ variants are not neccessary
> > > here.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> []
> > > struct bt_skb_cb {
> > > -	__u8 pkt_type;
> > > -	__u8 force_active;
> > > -	__u16 expect;
> > > -	__u8 incoming:1;
> > > +	u8 pkt_type;
> > > +	u8 force_active;
> > > +	u16 expect;
> > > +	u8 incoming:1;
> > > 	union {
> > > 		struct l2cap_ctrl l2cap;
> > > 		struct hci_ctrl hci;
> 
> trivia:
> 
> It's generally faster to use bool instead of u8 foo:1;

Ok, but I'm not changing that in this patch.

(And actually, bool will take a lot more memory, right?)
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-03 11:00 +0200
  Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Marcel Holtmann <marcel@holtmann.org> - 2016-10-05 13:20 +0200
    Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-05 20:00 +0200
      Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-05 21:20 +0200
        Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-05 21:20 +0200
          Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-06 00:20 +0200
            Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 00:30 +0200
              Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-06 09:10 +0200
                Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 09:10 +0200
                Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Johan Hedberg <johan.hedberg@gmail.com> - 2016-10-06 10:40 +0200
          RE: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel David Laight <David.Laight@ACULAB.COM> - 2016-10-06 11:50 +0200
            Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 13:40 +0200
              RE: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel David Laight <David.Laight@ACULAB.COM> - 2016-10-06 15:10 +0200
                Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Joe Perches <joe@perches.com> - 2016-10-06 17:50 +0200
  [PATCHv2] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Pavel Machek <pavel@ucw.cz> - 2016-10-05 23:00 +0200
    Re: [PATCHv2] bluetooth.h: __ variants of u8 and friends are not  neccessary inside kernel Marcel Holtmann <marcel@holtmann.org> - 2016-10-06 00:00 +0200

csiph-web