Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1497147

Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote:
> +struct sun4i_tcon_quirks {
> +	bool	is_sun5i;	/* sun5i has undocumented mux */
> +	bool	has_channel_1;	/* a33 does not have channel 1 */
> +	bool	has_bypass_src;	/* has separate input bypassing CEU */
> +	bool	has_dma_src;	/* has DMA input */
> +};
> +

I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't
really relate to what we're doing there, is redundant with the
compatible, and render the other quirks name useless, since we could
just have is_sun.i quirks and deal with that (which is essentially
what we were doing before).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] drm/sun4i: Support first display pipeline on sun6i Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
  [PATCH 5/9] drm/sun4i: Add compatible strings for A31/A31s display pipelines Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
    Re: [PATCH 5/9] drm/sun4i: Add compatible strings for A31/A31s  display pipelines Rob Herring <robh@kernel.org> - 2016-10-10 16:50 +0200
  [PATCH 7/9] ARM: dts: sun6i: Add device nodes for first display pipeline Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
  [PATCH 6/9] ARM: dts: sun6i: Sort pinmux setting nodes Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
    Re: [PATCH 6/9] ARM: dts: sun6i: Sort pinmux setting nodes Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-07 15:10 +0200
  [PATCH 4/9] drm/sun4i: Add compatible string for A31/A31s TCON (timing controller) Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
    Re: [PATCH 4/9] drm/sun4i: Add compatible string for A31/A31s TCON  (timing controller) Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-07 15:10 +0200
  [PATCH 8/9] ARM: dts: sun6i: Add A31 LCD0 RGB888 pins Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
  [PATCH 3/9] drm/sun4i: Put dotclock range into tcon quirks and check against them Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
    Re: [PATCH 3/9] drm/sun4i: Put dotclock range into tcon quirks and  check against them Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-07 15:10 +0200
  [PATCH 9/9] [DO NOT MERGE] ARM: dts: sun6i: Enable 7" LCD panel on Sinlinx SinA31s Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
  [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Chen-Yu Tsai <wens@csie.org> - 2016-10-06 18:10 +0200
    Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT  matched data structure Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-07 15:10 +0200
      Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT  matched data structure Chen-Yu Tsai <wens@csie.org> - 2016-10-11 11:20 +0200
        Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT  matched data structure Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-11 11:40 +0200

csiph-web