Re: [PATCH v6] powerpc: Do not make the entire heap executable

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] powerpc: Do not make the entire heap executable
Date	Tue, 04 Oct 2016 02:20:01 +0200
Message-ID	<solCF-3pp-3@gated-at.bofh.it> (permalink)
References	<soe8a-7gD-15@gated-at.bofh.it> <sojrc-1U9-13@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>, Kees Cook <keescook@chromium.org>, Denys Vlasenko <dvlasenk@redhat.com>
User-Agent	Notmuch/0.21 (https://notmuchmail.org)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	"linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Oleg Nesterov <oleg@redhat.com>, Florian Weimer <fweimer@redhat.com>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 04 Oct 2016 11:18:37 +1100
X-Original-Message-ID	<877f9p55lu.fsf@concordia.ellerman.id.au>
X-Original-References	<20161003161322.3835-1-dvlasenk@redhat.com> <CAGXu5j+haCUW_AEPLPcVGtrnv4ojQ79FDpspUurYJSX_-TXeow@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1495113

Show key headers only | View raw

Kees Cook <keescook@chromium.org> writes:

> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt,
>> or with a toolchain which defaults to it) look like this:
...
>>
>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>> Acked-by: Kees Cook <keescook@chromium.org>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> CC: Paul Mackerras <paulus@samba.org>
>> CC: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>> CC: Kees Cook <keescook@chromium.org>
>> CC: Oleg Nesterov <oleg@redhat.com>
>> CC: Michael Ellerman <mpe@ellerman.id.au>
>> CC: Florian Weimer <fweimer@redhat.com>
>> CC: linux-mm@kvack.org
>> CC: linuxppc-dev@lists.ozlabs.org
>> CC: linux-kernel@vger.kernel.org
>> ---
>> Changes since v5:
>> * made do_brk_flags() error out if any bits other than VM_EXEC are set.
>>   (Kees Cook: "With this, I'd be happy to Ack.")
>>   See https://patchwork.ozlabs.org/patch/661595/
>
> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree?

-mm would be best, given the diffstat I think it's less likely to
 conflict if it goes via -mm.

cheers

Thread

[PATCH v6] powerpc: Do not make the entire heap executable Denys Vlasenko <dvlasenk@redhat.com> - 2016-10-03 18:20 +0200
  Re: [PATCH v6] powerpc: Do not make the entire heap executable Kees Cook <keescook@chromium.org> - 2016-10-04 00:00 +0200
    Re: [PATCH v6] powerpc: Do not make the entire heap executable Michael Ellerman <mpe@ellerman.id.au> - 2016-10-04 02:20 +0200
      Re: [PATCH v6] powerpc: Do not make the entire heap executable Kees Cook <keescook@chromium.org> - 2016-10-04 19:00 +0200

csiph-web