Re: [PATCH v6] powerpc: Do not make the entire heap executable

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] powerpc: Do not make the entire heap executable
Date	2016-10-04 19:00 +0200
Message-ID	<soBep-5lJ-7@gated-at.bofh.it> (permalink)
References	<soe8a-7gD-15@gated-at.bofh.it> <sojrc-1U9-13@gated-at.bofh.it> <solCF-3pp-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Kees Cook <keescook@chromium.org> writes:
>
>> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt,
>>> or with a toolchain which defaults to it) look like this:
> ...
>>>
>>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>>> Acked-by: Kees Cook <keescook@chromium.org>
>>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> CC: Paul Mackerras <paulus@samba.org>
>>> CC: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>> CC: Kees Cook <keescook@chromium.org>
>>> CC: Oleg Nesterov <oleg@redhat.com>
>>> CC: Michael Ellerman <mpe@ellerman.id.au>
>>> CC: Florian Weimer <fweimer@redhat.com>
>>> CC: linux-mm@kvack.org
>>> CC: linuxppc-dev@lists.ozlabs.org
>>> CC: linux-kernel@vger.kernel.org
>>> ---
>>> Changes since v5:
>>> * made do_brk_flags() error out if any bits other than VM_EXEC are set.
>>>   (Kees Cook: "With this, I'd be happy to Ack.")
>>>   See https://patchwork.ozlabs.org/patch/661595/
>>
>> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree?
>
> -mm would be best, given the diffstat I think it's less likely to
>  conflict if it goes via -mm.

Okay, excellent. Andrew, do you have this already in email? I think
you weren't on the explicit CC from the v6...

-Kees

-- 
Kees Cook
Nexus Security

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6] powerpc: Do not make the entire heap executable Denys Vlasenko <dvlasenk@redhat.com> - 2016-10-03 18:20 +0200
  Re: [PATCH v6] powerpc: Do not make the entire heap executable Kees Cook <keescook@chromium.org> - 2016-10-04 00:00 +0200
    Re: [PATCH v6] powerpc: Do not make the entire heap executable Michael Ellerman <mpe@ellerman.id.au> - 2016-10-04 02:20 +0200
      Re: [PATCH v6] powerpc: Do not make the entire heap executable Kees Cook <keescook@chromium.org> - 2016-10-04 19:00 +0200

csiph-web