Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1495718

Re: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl
Date 2016-10-05 09:00 +0200
Message-ID <soOlj-5DW-7@gated-at.bofh.it> (permalink)
References <soEYF-7J5-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Oct 05, 2016 at 02:23:22AM +0530, Harman Kalra wrote:
> 2 errors "open brace { should be on the previous line" are fixed.
> Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed
> Few line more tahn 80 character warnings fixed

That's three different things, please make three different patches,
don't do multiple things in the same patch.

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Harman Kalra <harman4linux@gmail.com> - 2016-10-04 23:00 +0200
  Re: [PATCH] staging: i4l: icn: fixed some errors and warnings caught  by checkpatch.pl Greg KH <gregkh@linuxfoundation.org> - 2016-10-05 09:00 +0200
    [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Harman Kalra <harman4linux@gmail.com> - 2016-10-07 19:10 +0200
      Re: [PATCH 3/3] Staging: i4l: Error "open brace { should be on the  previous line" fixed. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:00 +0200
    [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Harman Kalra <harman4linux@gmail.com> - 2016-10-07 19:20 +0200
      [PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Harman Kalra <harman4linux@gmail.com> - 2016-10-07 19:20 +0200
        Re: [PATCH 2/3] Staging: i4l: Error "open brace { should be on the  previous line" fixed. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:10 +0200
          [PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra <harman4linux@gmail.com> - 2016-10-09 17:40 +0200
          [PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk Harman Kalra <harman4linux@gmail.com> - 2016-10-09 17:40 +0200
          [PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra <harman4linux@gmail.com> - 2016-10-09 17:40 +0200
      Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over  printk(KERN_DEBUG... " fixed Joe Perches <joe@perches.com> - 2016-10-07 23:00 +0200
      Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over  printk(KERN_DEBUG... " fixed Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:00 +0200

csiph-web