Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1495594
| From | Harman Kalra <harman4linux@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl |
| Date | 2016-10-04 23:00 +0200 |
| Message-ID | <soEYF-7J5-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
2 errors "open brace { should be on the previous line" are fixed.
Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed
Few line more tahn 80 character warnings fixed
Signed-off-by: Harman Kalra <harman4linux@gmail.com>
---
drivers/staging/i4l/icn/icn.c | 3 +--
drivers/staging/i4l/icn/icn.h | 7 ++++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 514bfc2..3750ba3 100644
--- a/drivers/staging/i4l/icn/icn.c
+++ b/drivers/staging/i4l/icn/icn.c
@@ -411,8 +411,7 @@
int action;
} icn_stat;
/* *INDENT-OFF* */
-static icn_stat icn_stat_table[] =
-{
+static icn_stat icn_stat_table[] = {
{"BCON_", ISDN_STAT_BCONN, 1}, /* B-Channel connected */
{"BDIS_", ISDN_STAT_BHUP, 2}, /* B-Channel disconnected */
/*
diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h
index f8f2e76..1e5a487 100644
--- a/drivers/staging/i4l/icn/icn.h
+++ b/drivers/staging/i4l/icn/icn.h
@@ -54,7 +54,8 @@
/* some useful macros for debugging */
#ifdef ICN_DEBUG_PORT
-#define OUTB_P(v, p) {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p);}
+#define OUTB_P(v, p) \
+ {pr_debug("icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p); }
#else
#define OUTB_P outb
#endif
@@ -186,8 +187,8 @@
#ifdef __KERNEL__
static icn_card *cards = (icn_card *) 0;
-static u_char chan2bank[] =
-{0, 4, 8, 12}; /* for icn_map_channel() */
+static u_char chan2bank[] = {
+ 0, 4, 8, 12}; /* for icn_map_channel() */
static icn_dev dev;
--
1.7.9.5
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Harman Kalra <harman4linux@gmail.com> - 2016-10-04 23:00 +0200
Re: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Greg KH <gregkh@linuxfoundation.org> - 2016-10-05 09:00 +0200
[PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Harman Kalra <harman4linux@gmail.com> - 2016-10-07 19:10 +0200
Re: [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:00 +0200
[PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Harman Kalra <harman4linux@gmail.com> - 2016-10-07 19:20 +0200
[PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Harman Kalra <harman4linux@gmail.com> - 2016-10-07 19:20 +0200
Re: [PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:10 +0200
[PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra <harman4linux@gmail.com> - 2016-10-09 17:40 +0200
[PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk Harman Kalra <harman4linux@gmail.com> - 2016-10-09 17:40 +0200
[PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error Harman Kalra <harman4linux@gmail.com> - 2016-10-09 17:40 +0200
Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Joe Perches <joe@perches.com> - 2016-10-07 23:00 +0200
Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:00 +0200
csiph-web