Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places
Date	2016-10-04 18:10 +0200
Message-ID	<soAs2-53L-1@gated-at.bofh.it> (permalink)
References	<smNMJ-7br-9@gated-at.bofh.it> <smNWp-7uF-1@gated-at.bofh.it> <sox17-2F6-9@gated-at.bofh.it> <sozPj-4AX-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-10-04 at 21:06 +0530, Vinod Koul wrote:
> On Tue, Oct 04, 2016 at 02:23:51PM +0200, Linus Walleij wrote:
> > On Thu, Sep 29, 2016 at 8:06 PM, Joe Perches <joe@perches.com> wrote:
> > > On Thu, 2016-09-29 at 18:57 +0100, Colin King wrote:
> > > > Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
> > > > be more than 32 places, which leads to a 32 bit integer overflow. Fix this
> > > > by casting 1 to a u64 (the same type as started_channels) before shifting
> > > > it.
> > > trivia:
> > > > diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
> > > []
> > > > @@ -1353,7 +1353,7 @@ static ssize_t coh901318_debugfs_read(struct file *file, char __user *buf,
> > > >       tmp += sprintf(tmp, "DMA -- enabled dma channels\n");
> > > > 
> > > >       for (i = 0; i < U300_DMA_CHANNELS; i++)
> > > > -             if (started_channels & (1 << i))
> > > > +             if (started_channels & ((u64)1 << i))
> > > Using
> > >                 if (started_channels & (1ULL << i))
> > > would be more common.
> > Even better (IMO):
> > #include <linux/bitops.h>
> > if (started_channels & BIT(i))
> > Apparently code is there to avoid the bit 31 problem, mea culpa.
> I have already applied this one, so feel free to send this as an update :)

BIT_ULL as it still needs to be u64 not unsigned long.

But if a change is really desired, please use it
consistently in the entire file and not just this
instance.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Colin King <colin.king@canonical.com> - 2016-09-29 20:00 +0200
  Re: [PATCH] dmaengine: coh901318: fix integer overflow when  shifting more than 32 places Joe Perches <joe@perches.com> - 2016-09-29 20:10 +0200
    Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting  more than 32 places Linus Walleij <linus.walleij@linaro.org> - 2016-10-04 14:30 +0200
      Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting  more than 32 places Vinod Koul <vinod.koul@intel.com> - 2016-10-04 17:30 +0200
        Re: [PATCH] dmaengine: coh901318: fix integer overflow when  shifting more than 32 places Joe Perches <joe@perches.com> - 2016-10-04 18:10 +0200

csiph-web