Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1493626
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places |
| Date | 2016-09-29 20:00 +0200 |
| Message-ID | <smNMJ-7br-9@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
From: Colin Ian King <colin.king@canonical.com> Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can be more than 32 places, which leads to a 32 bit integer overflow. Fix this by casting 1 to a u64 (the same type as started_channels) before shifting it. Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/dma/coh901318.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c index 2835f3e..98611e3 100644 --- a/drivers/dma/coh901318.c +++ b/drivers/dma/coh901318.c @@ -1353,7 +1353,7 @@ static ssize_t coh901318_debugfs_read(struct file *file, char __user *buf, tmp += sprintf(tmp, "DMA -- enabled dma channels\n"); for (i = 0; i < U300_DMA_CHANNELS; i++) - if (started_channels & (1 << i)) + if (started_channels & ((u64)1 << i)) tmp += sprintf(tmp, "channel %d\n", i); tmp += sprintf(tmp, "Pool alloc nbr %d\n", pool_count); -- 2.9.3
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Colin King <colin.king@canonical.com> - 2016-09-29 20:00 +0200
Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Joe Perches <joe@perches.com> - 2016-09-29 20:10 +0200
Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Linus Walleij <linus.walleij@linaro.org> - 2016-10-04 14:30 +0200
Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Vinod Koul <vinod.koul@intel.com> - 2016-10-04 17:30 +0200
Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Joe Perches <joe@perches.com> - 2016-10-04 18:10 +0200
csiph-web