Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *

From	Malcolm Priestley <tvboxspy@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *
Date	2016-09-30 21:00 +0200
Message-ID	<snbcl-5HB-9@gated-at.bofh.it> (permalink)
References	<sm3TA-3vI-37@gated-at.bofh.it> <sm4PD-441-5@gated-at.bofh.it> <sm4PD-441-9@gated-at.bofh.it> <smhMR-3RU-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/09/16 08:40, Dan Carpenter wrote:
> On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote:
>> Change the type and uses of rx_rate.
>>
>> Signed-off-by: Martin Alonso <martin.alonso@zoho.com>
>> ---
>>  drivers/staging/vt6656/dpc.c | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
>> index 655f000..782b7d7 100644
>> --- a/drivers/staging/vt6656/dpc.c
>> +++ b/drivers/staging/vt6656/dpc.c
>> @@ -46,7 +46,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
>>  	__le64 *tsf_time;
>>  	u32 frame_size;
>>  	int ii, r;
>> -	u8 *rx_rate, *sq, *sq_3;
>> +	u8 rx_rate;
>> +	u8 *sq, *sq_3;
>>  	u32 wbk_status;
>>  	u8 *skb_data;
>>  	u16 *pay_load_len;
>> @@ -75,7 +76,7 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
>>
>>  	skb_data = (u8 *)skb->data;
>>
>> -	rx_rate = skb_data + 5;
>> +	rx_rate = *(skb_data + 5);
>
> It occurs to me that we don't check that skb->len is large enough here.
> We just assume it has at least 5 bytes.
>
> TODO: vt6656: verify skb->len before using it.

skb->len is always set to the tail room then trimmed by this function.

Regards

Malcolm

Thread

[PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso <martin.alonso@zoho.com> - 2016-09-26 19:50 +0200
  Re: [PATCH] staging: vt6656: Add spaces around '+' operator Joe Perches <joe@perches.com> - 2016-09-26 20:10 +0200
    Re: [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 19:00 +0200
      [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 20:00 +0200
        Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-28 09:50 +0200
          Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Malcolm Priestley <tvboxspy@gmail.com> - 2016-09-30 21:00 +0200
            Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-30 21:40 +0200
        Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Greg KH <gregkh@linuxfoundation.org> - 2016-09-28 11:40 +0200
      [PATCH 1/2] staging: vt6656: Remove unused variable 'rx_sts' Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 20:00 +0200
  Re: [PATCH] staging: vt6656: Add spaces around '+' operator Greg KH <gregkh@linuxfoundation.org> - 2016-09-27 13:20 +0200
    Re: [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 13:50 +0200

csiph-web