Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491486

Re: [PATCH] staging: vt6656: Add spaces around '+' operator

Show all headers | View raw

On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote:
> Fix coding style issue "spaces preferred around '+'
> detected by checkpatch.pl in dpc.c file.
[]
> diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
[]
> @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
>  
> >  	skb_data = (u8 *)skb->data;
>  
> -	rx_sts = skb_data+4;
> -	rx_rate = skb_data+5;
> +	rx_sts = skb_data + 4;
> +	rx_rate = skb_data + 5;
>  
>  	/* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */
>  	/* -8TSF - 4RSR - 4SQ3 - ?Padding */

You might as well make rx_rate u8 instead of u8 *
and change the uses of rx_rate.  rx_sts isn't used
anywhere at all and could be removed.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso <martin.alonso@zoho.com> - 2016-09-26 19:50 +0200
  Re: [PATCH] staging: vt6656: Add spaces around '+' operator Joe Perches <joe@perches.com> - 2016-09-26 20:10 +0200
    Re: [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 19:00 +0200
      [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 20:00 +0200
        Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-28 09:50 +0200
          Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Malcolm Priestley <tvboxspy@gmail.com> - 2016-09-30 21:00 +0200
            Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-30 21:40 +0200
        Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Greg KH <gregkh@linuxfoundation.org> - 2016-09-28 11:40 +0200
      [PATCH 1/2] staging: vt6656: Remove unused variable 'rx_sts' Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 20:00 +0200
  Re: [PATCH] staging: vt6656: Add spaces around '+' operator Greg KH <gregkh@linuxfoundation.org> - 2016-09-27 13:20 +0200
    Re: [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso <martin.alonso@zoho.com> - 2016-09-27 13:50 +0200

csiph-web