Re: md/dm-crypt: Rename a jump label in crypt_message() ?

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: md/dm-crypt: Rename a jump label in crypt_message() ?
Date	2016-09-30 14:10 +0200
Message-ID	<sn4Nz-1Be-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <smpho-by-21@gated-at.bofh.it> <smJ6q-4eJ-9@gated-at.bofh.it> <smLKV-5Vi-7@gated-at.bofh.it> <sn2Vr-om-17@gated-at.bofh.it> <sn4ky-1bg-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 30, 2016 at 01:32:23PM +0200, SF Markus Elfring wrote:
> > I specifically did not say that "out:" or "error:" labels are bad names.
> 
> Did you inform me once that you had also a special opinion about an identifier
> like "out"?

I don't like out labels, but that's my opinion.  There is nothing in
CodingStyle which says you can't do it.

regards,
dan carpenter

Thread

[PATCH 00/10] md/dm-crypt: Fine-tuning for five function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:40 +0200
  [PATCH 06/10] md/dm-crypt: Delete an unnecessary variable  initialisation in crypt_set_key() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 04/10] md/dm-crypt: Delete an unnecessary variable  initialisation in crypt_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 08/10] md/dm-crypt: Return directly after a failed  crypto_alloc_ahash() in crypt_iv_essiv_ctr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 05/10] md/dm-crypt: Rename a jump label in crypt_set_key() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
    Re: [dm-devel] [PATCH 05/10] md/dm-crypt: Rename a jump label in  crypt_set_key() Theodore Ts'o <tytso@mit.edu> - 2016-09-29 15:00 +0200
  [PATCH 09/10] md/dm-crypt: Two checks and one function call less in  crypt_iv_essiv_ctr() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 10/10] md/dm-crypt: Delete unnecessary variable  initialisations in crypt_iv_essiv_ctr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
    Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in  crypt_message() Theodore Ts'o <tytso@mit.edu> - 2016-09-29 15:00 +0200
      Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in  crypt_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-29 17:50 +0200
        Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in  crypt_message() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-30 12:10 +0200
          Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 13:40 +0200
            Re: md/dm-crypt: Rename a jump label in crypt_message() ? Bjørn Mork <bjorn@mork.no> - 2016-09-30 13:50 +0200
              Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 14:00 +0200
                Re: md/dm-crypt: Rename a jump label in crypt_message() ? Bjørn Mork <bjorn@mork.no> - 2016-09-30 14:10 +0200
                Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 15:00 +0200
            Re: md/dm-crypt: Rename a jump label in crypt_message() ? Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-30 14:10 +0200
              Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 14:30 +0200
  [PATCH 07/10] md/dm-crypt: Rename a jump label in  crypt_iv_tcw_whitening() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200

csiph-web