Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1492664

[PATCH 08/10] md/dm-crypt: Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 08/10] md/dm-crypt: Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr()
Date 2016-09-28 17:50 +0200
Message-ID <smpho-by-25@gated-at.bofh.it> (permalink)
References <qEuGl-43C-5@gated-at.bofh.it> <smp7H-7L-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 28 Sep 2016 15:55:47 +0200

Return directly after a call of the function "crypto_alloc_ahash"
failed here.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/md/dm-crypt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index c457b5e..47f6265 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -375,8 +375,7 @@ static int crypt_iv_essiv_ctr(struct crypt_config *cc, struct dm_target *ti,
 	hash_tfm = crypto_alloc_ahash(opts, 0, CRYPTO_ALG_ASYNC);
 	if (IS_ERR(hash_tfm)) {
 		ti->error = "Error initializing ESSIV hash";
-		err = PTR_ERR(hash_tfm);
-		goto bad;
+		return PTR_ERR(hash_tfm);
 	}
 
 	salt = kzalloc(crypto_ahash_digestsize(hash_tfm), GFP_KERNEL);
-- 
2.10.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/10] md/dm-crypt: Fine-tuning for five function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:40 +0200
  [PATCH 06/10] md/dm-crypt: Delete an unnecessary variable  initialisation in crypt_set_key() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 04/10] md/dm-crypt: Delete an unnecessary variable  initialisation in crypt_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 08/10] md/dm-crypt: Return directly after a failed  crypto_alloc_ahash() in crypt_iv_essiv_ctr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 05/10] md/dm-crypt: Rename a jump label in crypt_set_key() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
    Re: [dm-devel] [PATCH 05/10] md/dm-crypt: Rename a jump label in  crypt_set_key() Theodore Ts'o <tytso@mit.edu> - 2016-09-29 15:00 +0200
  [PATCH 09/10] md/dm-crypt: Two checks and one function call less in  crypt_iv_essiv_ctr() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 10/10] md/dm-crypt: Delete unnecessary variable  initialisations in crypt_iv_essiv_ctr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
  [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200
    Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in  crypt_message() Theodore Ts'o <tytso@mit.edu> - 2016-09-29 15:00 +0200
      Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in  crypt_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-29 17:50 +0200
        Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in  crypt_message() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-30 12:10 +0200
          Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 13:40 +0200
            Re: md/dm-crypt: Rename a jump label in crypt_message() ? Bjørn Mork <bjorn@mork.no> - 2016-09-30 13:50 +0200
              Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 14:00 +0200
                Re: md/dm-crypt: Rename a jump label in crypt_message() ? Bjørn Mork <bjorn@mork.no> - 2016-09-30 14:10 +0200
                Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 15:00 +0200
            Re: md/dm-crypt: Rename a jump label in crypt_message() ? Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-30 14:10 +0200
              Re: md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 14:30 +0200
  [PATCH 07/10] md/dm-crypt: Rename a jump label in  crypt_iv_tcw_whitening() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-28 17:50 +0200

csiph-web