Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1492254

[PATCH 2/2] mfd: intel-lpss: Avoid resuming runtime-suspended lpss unnecessarily

Show all headers | View raw

We have report that the intel_lpss_prepare() takes too much time during
suspend, and this is because we first resume the devices from runtime
suspend by resume_lpss_device(), to make sure they are in proper state
before system suspend, which takes 100ms for each LPSS devices(PCI power
state from D3_cold to D0). And since resume_lpss_device() resumes the
devices synchronously, we might get huge latency if we have many
LPSS devices.

So first try is to use pm_request_resume() instead, to make the runtime
resume process asynchronously. Unfortunately the asynchronous runtime
resume relies on pm_wq, which is freezed at early stage. So we choose
another method, that is to avoid resuming runtime-suspended devices,
if they are already runtime suspended. This is safe because for LPSS
driver, the runtime suspend and system suspend are of the same
hook - i.e., intel_lpss_suspend(). And moreover, this device is
neither runtime wakeup source nor system wakeup source.

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
 drivers/mfd/intel-lpss.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 41b1138..2ba8d19 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -485,6 +485,15 @@ static int resume_lpss_device(struct device *dev, void *data)
 int intel_lpss_prepare(struct device *dev)
 {
 	/*
+	 * This is safe because:
+	 * 1. The runtime suspend and system suspend
+	 * are of the same hook.
+	 * 2. This device is neither runtime wakeup source
+	 * nor system wakeup source.
+	 */
+	if (pm_runtime_status_suspended(dev))
+		return RPM_SUSPENDED;
+	/*
 	 * Resume both child devices before entering system sleep. This
 	 * ensures that they are in proper state before they get suspended.
 	 */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Define positive return value to RPM_SUSPEND for runtime-suspended devices Chen Yu <yu.c.chen@intel.com> - 2016-09-28 05:20 +0200
  [PATCH 1/2] PM / sleep: Return RPM_SUSPENDED to keep devices in runtime-suspended Chen Yu <yu.c.chen@intel.com> - 2016-09-28 05:20 +0200
    Re: [PATCH 1/2] PM / sleep: Return RPM_SUSPENDED to keep devices in runtime-suspended "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-28 13:50 +0200
      Re: [PATCH 1/2] PM / sleep: Return RPM_SUSPENDED to keep devices in  runtime-suspended Chen Yu <yu.c.chen@intel.com> - 2016-09-28 17:00 +0200
  [PATCH 2/2] mfd: intel-lpss: Avoid resuming runtime-suspended lpss unnecessarily Chen Yu <yu.c.chen@intel.com> - 2016-09-28 05:30 +0200
    Re: [PATCH 2/2] mfd: intel-lpss: Avoid resuming runtime-suspended  lpss unnecessarily Oliver Neukum <oneukum@suse.com> - 2016-09-28 09:50 +0200
      Re: [PATCH 2/2] mfd: intel-lpss: Avoid resuming runtime-suspended  lpss unnecessarily Chen Yu <yu.c.chen@intel.com> - 2016-09-28 10:10 +0200
        Re: [PATCH 2/2] mfd: intel-lpss: Avoid resuming runtime-suspended  lpss unnecessarily Oliver Neukum <oneukum@suse.com> - 2016-09-28 10:20 +0200

csiph-web