Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC
Date	2016-09-29 19:00 +0200
Message-ID	<smMQG-6Co-13@gated-at.bofh.it> (permalink)
References	<s6klI-2uR-9@gated-at.bofh.it> <s6klI-2uR-37@gated-at.bofh.it> <smJzr-4DI-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 29 Sep 2016, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote:

> Hello Mika,
> 
> In line 1239 you specify "struct pci_bus *bus = dev->bus;"
> }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev)
>  		}
>  		break;
>  
> +	case INTEL_SPI_BXT: {
> +		unsigned int p2sb = PCI_DEVFN(13, 0);
> +		unsigned int spi = PCI_DEVFN(13, 2);
> +		struct pci_bus *bus = dev->bus;
> 
> but in line 1262 you are using dev->bus again. 
> +
> +		pci_bus_write_config_byte(dev->bus, p2sb, 0xe1, 0x1);
> 
> Sure this is not a runtime issue, but it would be nice to keep the coding-style consistent. 
> We could just use dev->bus for BXT SOCs, like the remaining parts of this driver do. 
> 
> Kind regards
> Matthias Kraemer

Please reply in-line.  It is considered bad etiquette to top-post like this.

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Mika Westerberg
> Sent: Montag, 15. August 2016 09:11
> To: linux-mtd@lists.infradead.org
> Cc: Brian Norris; David Woodhouse; Lee Jones; Peter Tyser; key.seong.lim@intel.com; Mika Westerberg; linux-kernel@vger.kernel.org
> Subject: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

Please fix your mailer.  This is crud and should not be quoted.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake  SoC "Kraemer, Matthias (Ferchau; ADITG/SW1)" <mkraemer@de.adit-jv.com> - 2016-09-29 15:30 +0200
  Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake  SoC Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-29 15:40 +0200
  Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake  SoC Lee Jones <lee.jones@linaro.org> - 2016-09-29 19:00 +0200

csiph-web