Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1493465
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC |
| Date | 2016-09-29 15:40 +0200 |
| Message-ID | <smJJ8-4Hb-37@gated-at.bofh.it> (permalink) |
| References | <s6klI-2uR-9@gated-at.bofh.it> <s6klI-2uR-37@gated-at.bofh.it> <smJzr-4DI-15@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Thu, Sep 29, 2016 at 01:19:30PM +0000, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote:
> Hello Mika,
>
> In line 1239 you specify "struct pci_bus *bus = dev->bus;"
> }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev)
> }
> break;
>
> + case INTEL_SPI_BXT: {
> + unsigned int p2sb = PCI_DEVFN(13, 0);
> + unsigned int spi = PCI_DEVFN(13, 2);
> + struct pci_bus *bus = dev->bus;
>
> but in line 1262 you are using dev->bus again.
> +
> + pci_bus_write_config_byte(dev->bus, p2sb, 0xe1, 0x1);
Good point. It is a typo, although works.
> Sure this is not a runtime issue, but it would be nice to keep the
> coding-style consistent. We could just use dev->bus for BXT SOCs,
> like the remaining parts of this driver do.
Or "bus". But yeah I agree it should be consistent.
Since it looks like this driver is not going to make it for v4.9, I'll
fix this up and resend the whole thing once v4.9-rc1 is released.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RE: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC "Kraemer, Matthias (Ferchau; ADITG/SW1)" <mkraemer@de.adit-jv.com> - 2016-09-29 15:30 +0200 Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-29 15:40 +0200 Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC Lee Jones <lee.jones@linaro.org> - 2016-09-29 19:00 +0200
csiph-web