Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages
Date	Mon, 26 Sep 2016 06:00:01 +0200
Message-ID	<slvfb-73m-7@gated-at.bofh.it> (permalink)
References	<slpjr-3kT-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QbBp7DUTiukUWQVJE27GKcARB1JZUp4aFekQiOz1NP0=; b=ch5QV7HMugQnQnJ3iufQsKEVjzwkrJY4orhe8BfrrW1Hic7jOM7BpCPqW0710SN3id w4TAMBfbgxtqtnfJtAajchHWcwfR20n8I9AuQYTAJgYiEzcs06uZyqKDleTPjREMlon/ of/T3OqM8gXXmXDb0mX/RJFnKZolpcrpkqH9w=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QbBp7DUTiukUWQVJE27GKcARB1JZUp4aFekQiOz1NP0=; b=LG0E6DaLmBsT/V3VvE76fMooUcjXJaOw+GSFpBCIlWWGPzqzr5w3qp0f2FWNiwNrzx hgY7Q9r4Z6os3KqTvSSGFjQ4K/NdeRbbJ3In7oLpwQrkLzd1PyWgPU7HwssFjdITjL0d EKRk23InP6vivm6gfgfb+f9OWgNWWDHmErJ8e0KpTrFDW20rcVNpNMEqqCf0WRtoeo+w fEQXZsZs2FSe1s0YlTjPlT5r6Ksn9EBHGamMTXtxO6+X9SVX6Z08dac0FZM24PmTElHF ZXB2QGIWWOouAXwj8ICoPtpt/di0+HsBW/2c4xrN7gjjXbkHUFluebLEeojSrPT4PbfJ kphg==
X-Gm-Message-State	AE9vXwMZw2pRvuVstVPsQTFFzd+0BzOBrI8JeUINZZjTf6qzAbzDHew7gD0+j32GMggLJBHQ
X-Received	by 10.98.95.129 with SMTP id t123mr34339163pfb.148.1474862008651; Sun, 25 Sep 2016 20:53:28 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	trivial@kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 26 Sep 2016 09:23:25 +0530
X-Original-Message-ID	<20160926035325.GE17336@vireshk-i7>
X-Original-References	<20160925213543.12267-1-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1491065

Show key headers only | View raw

On 25-09-16, 14:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trival fix, dev_err messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/cpufreq/kirkwood-cpufreq.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
> index be42f10..1b9bcd7 100644
> --- a/drivers/cpufreq/kirkwood-cpufreq.c
> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
> @@ -123,7 +123,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  
>  	priv.cpu_clk = of_clk_get_by_name(np, "cpu_clk");
>  	if (IS_ERR(priv.cpu_clk)) {
> -		dev_err(priv.dev, "Unable to get cpuclk");
> +		dev_err(priv.dev, "Unable to get cpuclk\n");
>  		return PTR_ERR(priv.cpu_clk);
>  	}
>  
> @@ -132,7 +132,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  
>  	priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
>  	if (IS_ERR(priv.ddr_clk)) {
> -		dev_err(priv.dev, "Unable to get ddrclk");
> +		dev_err(priv.dev, "Unable to get ddrclk\n");
>  		err = PTR_ERR(priv.ddr_clk);
>  		goto out_cpu;
>  	}
> @@ -142,7 +142,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  
>  	priv.powersave_clk = of_clk_get_by_name(np, "powersave");
>  	if (IS_ERR(priv.powersave_clk)) {
> -		dev_err(priv.dev, "Unable to get powersave");
> +		dev_err(priv.dev, "Unable to get powersave\n");
>  		err = PTR_ERR(priv.powersave_clk);
>  		goto out_ddr;
>  	}
> @@ -155,7 +155,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  	if (!err)
>  		return 0;
>  
> -	dev_err(priv.dev, "Failed to register cpufreq driver");
> +	dev_err(priv.dev, "Failed to register cpufreq driver\n");
>  
>  	clk_disable_unprepare(priv.powersave_clk);
>  out_ddr:

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages Colin King <colin.king@canonical.com> - 2016-09-25 23:40 +0200
  Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err  messages Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-26 06:00 +0200

csiph-web