Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491065

Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages

Show all headers | View raw

On 25-09-16, 14:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trival fix, dev_err messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/cpufreq/kirkwood-cpufreq.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
> index be42f10..1b9bcd7 100644
> --- a/drivers/cpufreq/kirkwood-cpufreq.c
> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
> @@ -123,7 +123,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  
>  	priv.cpu_clk = of_clk_get_by_name(np, "cpu_clk");
>  	if (IS_ERR(priv.cpu_clk)) {
> -		dev_err(priv.dev, "Unable to get cpuclk");
> +		dev_err(priv.dev, "Unable to get cpuclk\n");
>  		return PTR_ERR(priv.cpu_clk);
>  	}
>  
> @@ -132,7 +132,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  
>  	priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
>  	if (IS_ERR(priv.ddr_clk)) {
> -		dev_err(priv.dev, "Unable to get ddrclk");
> +		dev_err(priv.dev, "Unable to get ddrclk\n");
>  		err = PTR_ERR(priv.ddr_clk);
>  		goto out_cpu;
>  	}
> @@ -142,7 +142,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  
>  	priv.powersave_clk = of_clk_get_by_name(np, "powersave");
>  	if (IS_ERR(priv.powersave_clk)) {
> -		dev_err(priv.dev, "Unable to get powersave");
> +		dev_err(priv.dev, "Unable to get powersave\n");
>  		err = PTR_ERR(priv.powersave_clk);
>  		goto out_ddr;
>  	}
> @@ -155,7 +155,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>  	if (!err)
>  		return 0;
>  
> -	dev_err(priv.dev, "Failed to register cpufreq driver");
> +	dev_err(priv.dev, "Failed to register cpufreq driver\n");
>  
>  	clk_disable_unprepare(priv.powersave_clk);
>  out_ddr:

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages Colin King <colin.king@canonical.com> - 2016-09-25 23:40 +0200
  Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err  messages Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-26 06:00 +0200

csiph-web