Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1491012
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio |
| Date | 2016-09-26 02:40 +0200 |
| Message-ID | <sls7D-591-1@gated-at.bofh.it> (permalink) |
| References | <sl17s-56O-7@gated-at.bofh.it> <slnrj-2dL-13@gated-at.bofh.it> <slruV-4Hx-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, 25 Sep 2016, Christoph Hellwig wrote:
> On Sun, Sep 25, 2016 at 09:39:20PM +0200, Ondrej Zary wrote:
>
> > #define NCR5380_read(reg) \
> > + ioread8(((struct NCR5380_hostdata *)shost_priv(instance))->iomem + \
> > + ((struct NCR5380_hostdata *)shost_priv(instance))->offset + \
> > + (reg))
> > #define NCR5380_write(reg, value) \
> > - outb(value, instance->io_port + (reg))
> > + iowrite8(value, ((struct NCR5380_hostdata *)shost_priv(instance))->iomem + \
> > + ((struct NCR5380_hostdata *)shost_priv(instance))->offset + \
> > + (reg))
>
> Can we make these #defines point to inline helper functions that avoid
> the casting magic, e.g. something like
>
> static inline void g_NCR5380_write(struct Scsi_Host *instance, u32 reg,
> u8 value)
> {
> struct NCR5380_hostdata *host = shost_priv(instance);
>
> iowrite8(value, host->iomem, host->offset + reg);
> }
>
> #define NCR5380_write(reg, value)
> g_NCR5380_write(instance, reg, value)
Let's not do that yet. I have a patch series that fixes the type casting
and related issues that I will post soon. I expect that Ondrej's patches
will be ready before mine are, so I'll rebase mine on this work before I
ask him to test my patches.
--
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] g_NCR5380: Modernization Ondrej Zary <linux@rainbow-software.org> - 2016-09-24 21:50 +0200
[PATCH 3/3] g_NCR5380: Stop using scsi_module.c Ondrej Zary <linux@rainbow-software.org> - 2016-09-24 21:50 +0200
Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Christoph Hellwig <hch@infradead.org> - 2016-09-26 02:00 +0200
Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Finn Thain <fthain@telegraphics.com.au> - 2016-09-26 05:30 +0200
Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Ondrej Zary <linux@rainbow-software.org> - 2016-09-27 15:00 +0200
Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Finn Thain <fthain@telegraphics.com.au> - 2016-09-28 02:10 +0200
[PATCH 1/3] g_NCR5380: Remove deprecated __setup Ondrej Zary <linux@rainbow-software.org> - 2016-09-24 21:50 +0200
Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup Christoph Hellwig <hch@infradead.org> - 2016-09-26 01:50 +0200
Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup Finn Thain <fthain@telegraphics.com.au> - 2016-09-26 02:50 +0200
[PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Ondrej Zary <linux@rainbow-software.org> - 2016-09-25 21:40 +0200
Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Christoph Hellwig <hch@infradead.org> - 2016-09-26 02:00 +0200
Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Finn Thain <fthain@telegraphics.com.au> - 2016-09-26 02:40 +0200
Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Christoph Hellwig <hch@infradead.org> - 2016-09-26 02:50 +0200
Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Finn Thain <fthain@telegraphics.com.au> - 2016-09-28 02:50 +0200
csiph-web