Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491007

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c
Date 2016-09-26 02:00 +0200
Message-ID <slruV-4Hx-7@gated-at.bofh.it> (permalink)
References <sl17s-56O-7@gated-at.bofh.it> <sl17s-56O-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> +static int generic_NCR5380_isa_match(struct device *pdev, unsigned int ndev)
> +{
> +	struct Scsi_Host *sh = NULL;
> +
> +	sh = generic_NCR5380_hw_init(&driver_template, pdev, base[ndev],
> +				     irq[ndev], card[ndev]);
> +	if (!sh && base[ndev])
> +		printk(KERN_WARNING "Card not found at address 0x%03x\n",
> +				base[ndev]);
> +	if (!sh)
> +		return 0;
>  
> +	dev_set_drvdata(pdev, sh);

Any reason not to move the dev_set_drvdata into generic_NCR5380_hw_init?
That would also allow to properly propagate the error down to the
caller, which would be useful for the PNP case.

Otherwise this look great to me.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] g_NCR5380: Modernization Ondrej Zary <linux@rainbow-software.org> - 2016-09-24 21:50 +0200
  [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Ondrej Zary <linux@rainbow-software.org> - 2016-09-24 21:50 +0200
    Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Christoph Hellwig <hch@infradead.org> - 2016-09-26 02:00 +0200
    Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Finn Thain <fthain@telegraphics.com.au> - 2016-09-26 05:30 +0200
      Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Ondrej Zary <linux@rainbow-software.org> - 2016-09-27 15:00 +0200
        Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Finn Thain <fthain@telegraphics.com.au> - 2016-09-28 02:10 +0200
  [PATCH 1/3] g_NCR5380: Remove deprecated __setup Ondrej Zary <linux@rainbow-software.org> - 2016-09-24 21:50 +0200
    Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup Christoph Hellwig <hch@infradead.org> - 2016-09-26 01:50 +0200
    Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup Finn Thain <fthain@telegraphics.com.au> - 2016-09-26 02:50 +0200
  [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Ondrej Zary <linux@rainbow-software.org> - 2016-09-25 21:40 +0200
    Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Christoph Hellwig <hch@infradead.org> - 2016-09-26 02:00 +0200
      Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Finn Thain <fthain@telegraphics.com.au> - 2016-09-26 02:40 +0200
        Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Christoph Hellwig <hch@infradead.org> - 2016-09-26 02:50 +0200
    Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio Finn Thain <fthain@telegraphics.com.au> - 2016-09-28 02:50 +0200

csiph-web