Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490909

[PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t

From Sergio Paracuellos <sergio.paracuellos@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t
Date 2016-09-25 15:40 +0200
Message-ID <slhOW-7ag-41@gated-at.bofh.it> (permalink)
References <slf0K-5rI-7@gated-at.bofh.it> <slhOV-7ag-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs

It applies for typedef p80211item_pstr32_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/wlan-ng/cfg80211.c         | 4 ++--
 drivers/staging/wlan-ng/p80211metastruct.h | 8 ++++----
 drivers/staging/wlan-ng/p80211types.h      | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 9f05c17..182b2d5 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -86,8 +86,8 @@ static int prism2_domibset_pstr32(struct wlandevice *wlandev,
 				  u32 did, u8 len, const u8 *data)
 {
 	struct p80211msg_dot11req_mibset msg;
-	p80211item_pstr32_t *mibitem =
-			(p80211item_pstr32_t *)&msg.mibattribute.data;
+	struct p80211item_pstr32 *mibitem =
+			(struct p80211item_pstr32 *)&msg.mibattribute.data;
 
 	msg.msgcode = DIDmsg_dot11req_mibset;
 	mibitem->did = did;
diff --git a/drivers/staging/wlan-ng/p80211metastruct.h b/drivers/staging/wlan-ng/p80211metastruct.h
index c9d4bb5..c66fc5a 100644
--- a/drivers/staging/wlan-ng/p80211metastruct.h
+++ b/drivers/staging/wlan-ng/p80211metastruct.h
@@ -70,7 +70,7 @@ struct p80211msg_dot11req_scan {
 	struct p80211item_uint32 bsstype;
 	struct p80211item_pstr6 bssid;
 	u8 pad_0C[1];
-	p80211item_pstr32_t ssid;
+	struct p80211item_pstr32 ssid;
 	u8 pad_1D[3];
 	struct p80211item_uint32 scantype;
 	struct p80211item_uint32 probedelay;
@@ -93,7 +93,7 @@ struct p80211msg_dot11req_scan_results {
 	struct p80211item_uint32 noise;
 	struct p80211item_pstr6 bssid;
 	u8 pad_3C[1];
-	p80211item_pstr32_t ssid;
+	struct p80211item_pstr32 ssid;
 	u8 pad_4D[3];
 	struct p80211item_uint32 bsstype;
 	struct p80211item_uint32 beaconperiod;
@@ -136,7 +136,7 @@ struct p80211msg_dot11req_start {
 	u32 msgcode;
 	u32 msglen;
 	u8 devname[WLAN_DEVNAMELEN_MAX];
-	p80211item_pstr32_t ssid;
+	struct p80211item_pstr32 ssid;
 	u8 pad_12D[3];
 	struct p80211item_uint32 bsstype;
 	struct p80211item_uint32 beaconperiod;
@@ -217,7 +217,7 @@ struct p80211msg_lnxreq_autojoin {
 	u32 msgcode;
 	u32 msglen;
 	u8 devname[WLAN_DEVNAMELEN_MAX];
-	p80211item_pstr32_t ssid;
+	struct p80211item_pstr32 ssid;
 	u8 pad_19D[3];
 	struct p80211item_uint32 authtype;
 	struct p80211item_uint32 resultcode;
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h
index 4d70d84..6c87729 100644
--- a/drivers/staging/wlan-ng/p80211types.h
+++ b/drivers/staging/wlan-ng/p80211types.h
@@ -294,12 +294,12 @@ struct p80211item_pstr14 {
 } __packed;
 
 /* message data item for OCTETSTR, DISPLAYSTR */
-typedef struct p80211item_pstr32 {
+struct p80211item_pstr32 {
 	u32 did;
 	u16 status;
 	u16 len;
 	struct p80211pstr32 data;
-} __packed p80211item_pstr32_t;
+} __packed;
 
 /* message data item for OCTETSTR, DISPLAYSTR */
 typedef struct p80211item_pstr255 {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-23 16:00 +0200
  Re: [PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t Greg KH <gregkh@linuxfoundation.org> - 2016-09-25 12:40 +0200
    [PATCH v2 03/17] staging: wlan-ng: avoid new typedef: p80211pstr6_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 14/17] staging: wlan-ng: avoid new typedef: p80211item_unk392_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 02/17] staging: wlan-ng: avoid new typedef: p80211pstr255_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 16/17] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 11/17] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 13/17] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 10/17] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 05/17] staging: wlan-ng: avoid new typedef: p80211pstr32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 06/17] staging: wlan-ng: avoid new typedef: p80211macarray_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 17/17] staging: wlan-ng: fix block comments style errors Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      Re: [PATCH v2 17/17] staging: wlan-ng: fix block comments style  errors Christoph Carlsen <christoph.carlsen@fff.in.tum.de> - 2016-09-25 16:00 +0200
    [PATCH v2 07/17] staging: wlan-ng: avoid new typedef: p80211item_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 15/17] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 01/17] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 00/17] staging: wlan-ng: fix some style issues in p80211types.h Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      [PATCH v2 04/17] staging: wlan-ng: avoid new typedef: p80211pstr14_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      [PATCH v2 09/17] staging: wlan-ng: avoid new typedef: p80211item_uint32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      [PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200

csiph-web