Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490894

[PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t

From Sergio Paracuellos <sergio.paracuellos@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t
Date 2016-09-25 15:40 +0200
Message-ID <slhOV-7ag-7@gated-at.bofh.it> (permalink)
References <slf0K-5rI-7@gated-at.bofh.it> <slhOV-7ag-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs

It applies for typedef p80211itemd_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/wlan-ng/p80211req.c   | 2 +-
 drivers/staging/wlan-ng/p80211types.h | 4 ++--
 drivers/staging/wlan-ng/prism2fw.c    | 4 ++--
 drivers/staging/wlan-ng/prism2mib.c   | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
index 61962d7..d43e85b 100644
--- a/drivers/staging/wlan-ng/p80211req.c
+++ b/drivers/staging/wlan-ng/p80211req.c
@@ -195,7 +195,7 @@ static void p80211req_mibset_mibget(struct wlandevice *wlandev,
 				   struct p80211msg_dot11req_mibget *mib_msg,
 				   int isget)
 {
-	p80211itemd_t *mibitem = (p80211itemd_t *)mib_msg->mibattribute.data;
+	struct p80211itemd *mibitem = (struct p80211itemd *)mib_msg->mibattribute.data;
 	struct p80211pstrd *pstr = (struct p80211pstrd *)mibitem->data;
 	u8 *key = mibitem->data + sizeof(struct p80211pstrd);
 
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h
index 6540044..57a65a8 100644
--- a/drivers/staging/wlan-ng/p80211types.h
+++ b/drivers/staging/wlan-ng/p80211types.h
@@ -262,12 +262,12 @@ struct p80211item {
 } __packed;
 
 /* prototype template w/ data item */
-typedef struct p80211itemd {
+struct p80211itemd {
 	u32 did;
 	u16 status;
 	u16 len;
 	u8 data[0];
-} __packed p80211itemd_t;
+} __packed;
 
 /* message data item for int, BOUNDEDINT, ENUMINT */
 typedef struct p80211item_uint32 {
diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 870bad9..7c5d3e7 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -243,7 +243,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
 {
 	signed int result = 0;
 	struct p80211msg_dot11req_mibget getmsg;
-	p80211itemd_t *item;
+	struct p80211itemd *item;
 	u32 *data;
 
 	/* Initialize the data structures */
@@ -293,7 +293,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
 	getmsg.resultcode.did = DIDmsg_dot11req_mibget_resultcode;
 	getmsg.resultcode.status = P80211ENUM_msgitem_status_no_value;
 
-	item = (p80211itemd_t *)getmsg.mibattribute.data;
+	item = (struct p80211itemd *)getmsg.mibattribute.data;
 	item->did = DIDmib_p2_p2NIC_p2PRISupRange;
 	item->status = P80211ENUM_msgitem_status_no_value;
 
diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
index e022de4..3442de3 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -266,7 +266,7 @@ int prism2mgmt_mibset_mibget(struct wlandevice *wlandev, void *msgp)
 	u16 which;
 
 	struct p80211msg_dot11req_mibset *msg = msgp;
-	p80211itemd_t *mibitem;
+	struct p80211itemd *mibitem;
 
 	msg->resultcode.status = P80211ENUM_msgitem_status_data_ok;
 	msg->resultcode.data = P80211ENUM_resultcode_success;
@@ -284,7 +284,7 @@ int prism2mgmt_mibset_mibget(struct wlandevice *wlandev, void *msgp)
 	 ** MIB table.
 	 */
 
-	mibitem = (p80211itemd_t *)msg->mibattribute.data;
+	mibitem = (struct p80211itemd *)msg->mibattribute.data;
 
 	for (mib = mibtab; mib->did != 0; mib++)
 		if (mib->did == mibitem->did && (mib->flag & which))
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-23 16:00 +0200
  Re: [PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t Greg KH <gregkh@linuxfoundation.org> - 2016-09-25 12:40 +0200
    [PATCH v2 03/17] staging: wlan-ng: avoid new typedef: p80211pstr6_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 14/17] staging: wlan-ng: avoid new typedef: p80211item_unk392_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 02/17] staging: wlan-ng: avoid new typedef: p80211pstr255_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 16/17] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 11/17] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 13/17] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 10/17] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 05/17] staging: wlan-ng: avoid new typedef: p80211pstr32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 06/17] staging: wlan-ng: avoid new typedef: p80211macarray_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 17/17] staging: wlan-ng: fix block comments style errors Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      Re: [PATCH v2 17/17] staging: wlan-ng: fix block comments style  errors Christoph Carlsen <christoph.carlsen@fff.in.tum.de> - 2016-09-25 16:00 +0200
    [PATCH v2 07/17] staging: wlan-ng: avoid new typedef: p80211item_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 15/17] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 01/17] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
    [PATCH v2 00/17] staging: wlan-ng: fix some style issues in p80211types.h Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      [PATCH v2 04/17] staging: wlan-ng: avoid new typedef: p80211pstr14_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      [PATCH v2 09/17] staging: wlan-ng: avoid new typedef: p80211item_uint32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200
      [PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-25 15:40 +0200

csiph-web