Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1491266
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: ISDN-CAPI: Adjust 17 function calls together with variable assignments |
| Date | 2016-09-26 14:40 +0200 |
| Message-ID | <slDmp-3Pp-23@gated-at.bofh.it> (permalink) |
| References | <slfDr-5Uj-5@gated-at.bofh.it> <slfDs-5Uj-17@gated-at.bofh.it> <slAeR-20r-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> The script "checkpatch.pl" can point out that assignments should usually >> not be performed within condition checks. >> Thus move the assignment for a variable to a separate statement >> in four functions. > > Did you recycle this commit explanation? Yes. - I am going to use similar commit messages for further changes in other software modules. > Because git diff tells me you actually touched about eight functions. You are right. - I'm sorry that I overlooked to update this number somehow. > scripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -l > > It tells me there are actually 18 instances of this "ERROR". > Why did you ignore one of it in this patch? Did I accidentally leave another update candidate over? * How do you think about to pick such a software update opportunity up? * Do you expect a resend for the steps 3 - 5 of this small patch series? Regards, Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] ISDN-CAPI: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 13:20 +0200
[PATCH 3/5] ISDN-CAPI: Adjust 17 function calls together with variable assignments SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 13:20 +0200
Re: [PATCH 3/5] ISDN-CAPI: Adjust 17 function calls together with variable assignments Paul Bolle <pebolle@tiscali.nl> - 2016-09-26 11:20 +0200
Re: ISDN-CAPI: Adjust 17 function calls together with variable assignments SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-26 14:40 +0200
[PATCH 4/5] ISDN-CAPI: Adjust checks for null pointers in four functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 13:20 +0200
[PATCH 2/5] ISDN-CAPI: Delete error messages for a failed memory allocation in four functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 13:20 +0200
csiph-web