Re: [PATCH] brcmfmac: implement more accurate skb tracking

From	Rafał Miłecki <zajec5@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] brcmfmac: implement more accurate skb tracking
Date	2016-09-26 14:20 +0200
Message-ID	<slD33-3J5-13@gated-at.bofh.it> (permalink)
References	<slBkC-2G3-29@gated-at.bofh.it> <slCA2-3kx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26 September 2016 at 13:46, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
> On 26-9-2016 12:23, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> We need to track 802.1x packets to know if there are any pending ones
>> for transmission. This is required for performing key update in the
>> firmware.
>
> The problem we are trying to solve is a pretty old one. The problem is
> that wpa_supplicant uses two separate code paths: EAPOL messaging
> through data path and key configuration though nl80211.

Can I find it described/reported somewhere?


>> Unfortunately our old tracking code wasn't very accurate. It was
>> treating skb as pending as soon as it was passed by the netif. Actual
>> handling packet to the firmware was happening later as brcmfmac
>> internally queues them and uses its own worker(s).
>
> That does not seem right. As soon as we get a 1x packet we need to wait
> with key configuration regardless whether it is still in the driver or
> handed over to firmware already.

OK, thanks.

Thread

[PATCH] brcmfmac: implement more accurate skb tracking Rafał Miłecki <zajec5@gmail.com> - 2016-09-26 12:30 +0200
  Re: [PATCH] brcmfmac: implement more accurate skb tracking Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-09-26 13:50 +0200
    Re: [PATCH] brcmfmac: implement more accurate skb tracking Rafał Miłecki <zajec5@gmail.com> - 2016-09-26 14:20 +0200
      Re: [PATCH] brcmfmac: implement more accurate skb tracking Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-09-26 14:30 +0200
      Re: [PATCH] brcmfmac: implement more accurate skb tracking Rafał Miłecki <zajec5@gmail.com> - 2016-09-26 14:40 +0200
        Re: [PATCH] brcmfmac: implement more accurate skb tracking Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-09-27 11:30 +0200
          Re: [PATCH] brcmfmac: implement more accurate skb tracking Rafał Miłecki <zajec5@gmail.com> - 2016-09-30 00:00 +0200
            Re: [PATCH] brcmfmac: implement more accurate skb tracking Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-09-30 10:40 +0200
      Re: [PATCH] brcmfmac: implement more accurate skb tracking Dan Williams <dcbw@redhat.com> - 2016-09-26 17:00 +0200
        Re: [PATCH] brcmfmac: implement more accurate skb tracking Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-09-27 11:10 +0200

csiph-web