Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490136

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

Show all headers | View raw

I believed I tested it but I found out that the CONFIG_OF_RESERVED_MEM
was not enabled in my config.
So it was not properly tested.
I will try to test it again.

Sorry,
Yannis

On Fri, Sep 23, 2016 at 3:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote:
>> This patch removes the empty function rmem_ion_device_release
>>
>> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
>> ---
>>  drivers/staging/android/ion/ion_of.c | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
>> index 49f052c..91c0642 100644
>> --- a/drivers/staging/android/ion/ion_of.c
>> +++ b/drivers/staging/android/ion/ion_of.c
>> @@ -158,15 +158,8 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev)
>>       return 0;
>>  }
>>
>> -static void rmem_ion_device_release(struct reserved_mem *rmem,
>> -                                 struct device *dev)
>> -{
>> -     return;
>> -}
>> -
>>  static const struct reserved_mem_ops rmem_dma_ops = {
>>       .device_init    = rmem_ion_device_init,
>> -     .device_release = rmem_ion_device_release,
>>  };
>>
>>  static int __init rmem_ion_setup(struct reserved_mem *rmem)
>> --
>> 2.10.0
>
> Have you tested that this works?
>
> thanks,
>
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging:android:io: Fix multiple styling issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-22 20:00 +0200
  Re: [PATCH] staging:android:io: Fix multiple styling issues Markus Böhme <markus.boehme@mailbox.org> - 2016-09-22 20:30 +0200
    [PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
      Re: [PATCHv2 5/5] staging:android:ion: Fix void function return Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 10:50 +0200
        [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-23 12:00 +0200
          Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:10 +0200
            Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-23 16:00 +0200
            Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-26 12:20 +0200
              Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Greg KH <gregkh@linuxfoundation.org> - 2016-09-26 12:30 +0200
                Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-26 12:40 +0200
          Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:20 +0200
            [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
              [PATCHv4 3/4] staging:android:ion: Fix blank line issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
              [PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
              [PATCHv4 4/4] staging:android:ion: Fix whitespace issue Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
    [PATCHv2 4/5] staging:android:ion: Fix switch case indentation giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
    [PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
      Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:20 +0200
        Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-23 15:30 +0200
          Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 17:10 +0200
    [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
      [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
        Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:20 +0200

csiph-web