Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1489826
| From | giannis.damigos@gmail.com |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL |
| Date | 2016-09-23 10:10 +0200 |
| Message-ID | <sktIt-19y-3@gated-at.bofh.it> (permalink) |
| References | <skgUW-1qI-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Yannis Damigos <giannis.damigos@gmail.com>
This patch fixes the following comparison with NULL issues:
CHECK: Comparison to NULL could be written "compatible[i].name"
+ for (i = 0; compatible[i].name != NULL; i++) {
CHECK: Comparison to NULL could be written "!compatible[i].name"
+ if (compatible[i].name == NULL)
Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
---
drivers/staging/android/ion/ion_of.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index de0899a..b3da8d8 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -31,12 +31,12 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
{
int i;
- for (i = 0; compatible[i].name != NULL; i++) {
+ for (i = 0; compatible[i].name; i++) {
if (of_device_is_compatible(heap_node, compatible[i].compat))
break;
}
- if (compatible[i].name == NULL)
+ if (!compatible[i].name)
return -ENODEV;
heap->id = compatible[i].heap_id;
--
2.10.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging:android:io: Fix multiple styling issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-22 20:00 +0200
Re: [PATCH] staging:android:io: Fix multiple styling issues Markus Böhme <markus.boehme@mailbox.org> - 2016-09-22 20:30 +0200
[PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
Re: [PATCHv2 5/5] staging:android:ion: Fix void function return Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 10:50 +0200
[PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-23 12:00 +0200
Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:10 +0200
Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-23 16:00 +0200
Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-26 12:20 +0200
Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Greg KH <gregkh@linuxfoundation.org> - 2016-09-26 12:30 +0200
Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-26 12:40 +0200
Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:20 +0200
[PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
[PATCHv4 3/4] staging:android:ion: Fix blank line issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
[PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
[PATCHv4 4/4] staging:android:ion: Fix whitespace issue Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-27 09:50 +0200
[PATCHv2 4/5] staging:android:ion: Fix switch case indentation giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
[PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:20 +0200
Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Yannis Damigos <giannis.damigos@gmail.com> - 2016-09-23 15:30 +0200
Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 17:10 +0200
[PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
[PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos@gmail.com - 2016-09-23 10:10 +0200
Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 14:20 +0200
csiph-web