Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490050

Re: GPU-DRM-TILCDC: Less function calls in tilcdc_convert_slave_node() after error detection

Show all headers | View raw

On Fri, Sep 23, 2016 at 8:17 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>>> I see a need to improve not only correctness there but also a bit of
>>> software efficiency.
>>
>> If you can measure any performance difference and present some results
>> (esp. considering that this is something that just happens when the
>> driver is loaded), then we'll talk.
>
> Are you really interested to increase your software development attention
> for a quicker exception handling implementation in this function?
>

No one is interested in making error handling more complex for a
non-existent benefit ;-)

>
>> Until then, please don't send this sort of patch.  Thank you.
>
> Will benchmark statistics change such a change rejection ever?

If you could demonstrate a real benefit to additional complexity for
something that actually matters (ie. not something like this that runs
once at bootup) I would care.

I don't recommend that you waste your time, since there is
approximately nothing in modesetting path that happens with a high
enough frequency to benefit from such a micro-optimization.
Especially not initialization code that runs once at boot up.

Fixing actual bugs is useful and valuable.  Premature "optimization"
at the expense of extra complexity is very much not useful.

BR,
-R

> Regards,
> Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] GPU-DRM-TILCDC: Fine-tuning for two function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 10:40 +0200
  [PATCH 2/4] GPU-DRM-TILCDC: Return directly after a failed  kfree_table_init() in tilcdc_convert_slave_node() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 10:40 +0200
    Re: [PATCH 2/4] GPU-DRM-TILCDC: Return directly after a failed  kfree_table_init() in tilcdc_convert_slave_node() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-22 13:00 +0200
    Re: [PATCH 2/4] GPU-DRM-TILCDC: Return directly after a failed  kfree_table_init() in tilcdc_convert_slave_node() Jyri Sarha <jsarha@ti.com> - 2016-09-22 19:00 +0200
      Re: GPU-DRM-TILCDC: Return directly after a failed kfree_table_init()  in tilcdc_convert_slave_node() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 20:20 +0200
  [PATCH 3/4] GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 10:40 +0200
    Re: [PATCH 3/4] GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection Jyri Sarha <jsarha@ti.com> - 2016-09-22 19:10 +0200
      Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 20:40 +0200
        Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection Jyri Sarha <jsarha@ti.com> - 2016-09-22 22:30 +0200
          Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 09:40 +0200
            Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection Jyri Sarha <jsarha@ti.com> - 2016-09-23 12:40 +0200
              Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 13:00 +0200
        Re: GPU-DRM-TILCDC: Less function calls in tilcdc_convert_slave_node()  after error detection Rob Clark <robdclark@gmail.com> - 2016-09-23 13:00 +0200
          Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 13:30 +0200
            Re: GPU-DRM-TILCDC: Less function calls in tilcdc_convert_slave_node()  after error detection Rob Clark <robdclark@gmail.com> - 2016-09-23 13:40 +0200
              Re: GPU-DRM-TILCDC: Less function calls in  tilcdc_convert_slave_node() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 14:20 +0200
                Re: GPU-DRM-TILCDC: Less function calls in tilcdc_convert_slave_node()  after error detection Rob Clark <robdclark@gmail.com> - 2016-09-23 15:10 +0200
  [PATCH 4/4] GPU-DRM-TILCDC: Delete unnecessary variable  initialisations in tilcdc_convert_slave_node() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 10:40 +0200

csiph-web