Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489628

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

Show all headers | View raw

On Thu, Sep 22, 2016 at 12:49:31PM -0700, Eric Biggers wrote:
> 
> Ted had actually pointed out that the reason this hasn't already been fixed is
> that some users, e.g. Android, do not set the feature flag but still expect the
> filesystem encryption code to work.  Maybe he can chime in with regards to when
> (if ever) it would make sense to make this change.

I think it's fine to fix it now in upstream.  It might cause some
problems for Cyanogen developers if they want to try to use an
upstream kernel and also enable the ext4 encryption feature, but the
fix to make_ext4fs isn't all that hard.

> Also, it seems the default block size for mkfs.ext4 is determined by a heuristic
> and isn't guaranteed to be 1 KiB.  So the commit message probably should say
> something more general like "filesystems created with a block size other than
> PAGE_SIZE".

In fact mke2fs only uses 1k block sizes for filessystems smaller than
512M.  If you were take a census of all ext4 file systems out there,
the most common block size you would see is 4k.

Cheers,

						- Ted

       	  	       	    	     	  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: Check for encryption feature before fscrypt_process_policy() Richard Weinberger <richard@nod.at> - 2016-09-22 09:00 +0200
  Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Eric Biggers <ebiggers@google.com> - 2016-09-22 21:50 +0200
    Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Richard Weinberger <richard@nod.at> - 2016-09-22 22:20 +0200
    Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Theodore Ts'o <tytso@mit.edu> - 2016-09-23 00:50 +0200
      Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Eric Biggers <ebiggers@google.com> - 2016-09-24 00:00 +0200
  Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Theodore Ts'o <tytso@mit.edu> - 2016-09-30 08:00 +0200

csiph-web