Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488581

[PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

Show all headers | View raw

...otherwise an user can enable encryption for certain files even
when the filesystem is unable to support it.
Such a case would be a filesystem created by mkfs.ext4's default
settings, 1KiB block size. Ext4 supports encyption only when block size
is equal to PAGE_SIZE.
But this constraint is only checked when the encryption feature flag
is set.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 fs/ext4/ioctl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 1bb7df5..9e9a73e 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -772,6 +772,9 @@ resizefs_out:
 #ifdef CONFIG_EXT4_FS_ENCRYPTION
 		struct fscrypt_policy policy;
 
+		if (!ext4_has_feature_encrypt(sb))
+			return -EOPNOTSUPP;
+
 		if (copy_from_user(&policy,
 				   (struct fscrypt_policy __user *)arg,
 				   sizeof(policy)))
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: Check for encryption feature before fscrypt_process_policy() Richard Weinberger <richard@nod.at> - 2016-09-22 09:00 +0200
  Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Eric Biggers <ebiggers@google.com> - 2016-09-22 21:50 +0200
    Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Richard Weinberger <richard@nod.at> - 2016-09-22 22:20 +0200
    Re: [PATCH] ext4: Check for encryption feature before  fscrypt_process_policy() Theodore Ts'o <tytso@mit.edu> - 2016-09-23 00:50 +0200

csiph-web