Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1489625

Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder switch to .eh_frame)

From Daniel Mentz <danielmentz@google.com>
Newsgroups linux.kernel
Subject Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder switch to .eh_frame)
Date 2016-09-23 00:40 +0200
Message-ID <skkOR-3Qd-9@gated-at.bofh.it> (permalink)
References <sjeBP-2xm-7@gated-at.bofh.it> <sji2J-4LH-1@gated-at.bofh.it> <skjg6-2JH-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Sep 22, 2016 at 1:59 PM, Vineet Gupta
<Vineet.Gupta1@synopsys.com> wrote:
> Hi Daniel,
>
> On 09/19/2016 06:21 PM, Daniel Mentz wrote:
>> I confirmed that the .eh_frame section is present and that the
>> .debug_frame section is absent. I also verified that the file size of
>> the .ko files are small enough for our embedded platform and that
>> unnecessary sections like .debug_info, .debug_line, .debug_str etc.
>> are also absent.
>
> BTW it seems with my latest set of patches, modules still have .debug_*.
> Can you double check if your tree still has the interim patch which added a linker
> script for modules to strip out .debug_*
>
> http://lists.infradead.org/pipermail/linux-snps-arc/2016-September/001483.html

Hi Vineet,

Sorry, that was a misunderstanding. Buildroot routinely runs the strip
command on .ko files before installing them on the target. I was only
looking at the .ko files *after* running the strip command. No, the
interim patch was not in my tree.

I confirmed that your commit "ARC: dw2 unwind: don't force dwarf 2" is
indeed necessary to suppress the .debug_* sections when
CONFIG_DEBUG_INFO is off. But again, we're stripping .ko files anyways
before installing.

> I'm not planning to carry it and would prefer addressing the the root cause by
> removing the -gdwarf-2 toggle. I've added that and pushed rebased series. Care to
> take it for a respin please.

I downloaded your latest commit
e47305af57d7eedc10b4720e604d669b10c69e3b and verified that stack
traces are properly displayed for code inside kernel modules as well
as vmlinux. I also called memcpy() on some bad address and got a
proper stack trace that involved memcpy().

I conclude that unwinding works for us.

Thank You
 Daniel

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] ARC unwinder switch to .eh_frame Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-19 23:50 +0200
  [PATCH 1/3] ARC: module: support R_ARC_32_PCREL relocation Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-19 23:50 +0200
  [PATCH 2/3] ARC: dw2 unwind: factor CIE specifics for .eh_frame/.debug_frame Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-20 00:00 +0200
  [PATCH 3/3] ARC: dw2 unwind: switch to .eh_frame based unwinding Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-20 00:00 +0200
  Re: [PATCH 0/3] ARC unwinder switch to .eh_frame Daniel Mentz <danielmentz@google.com> - 2016-09-20 03:30 +0200
    Re: [PATCH 0/3] ARC unwinder switch to .eh_frame Vineet Gupta <vgupta@synopsys.com> - 2016-09-20 08:20 +0200
      Re: [PATCH 0/3] ARC unwinder switch to .eh_frame Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-22 22:40 +0200
    modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder switch  to .eh_frame) Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-22 23:00 +0200
      Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder  switch to .eh_frame) Daniel Mentz <danielmentz@google.com> - 2016-09-23 00:40 +0200
        Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder  switch to .eh_frame) Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-09-23 12:40 +0200
          Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder  switch to .eh_frame) Daniel Mentz <danielmentz@google.com> - 2016-09-24 03:10 +0200
            Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder  switch to .eh_frame) Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-09-26 14:40 +0200
              Re: modules still have .debug_* (was Re: [PATCH 0/3] ARC unwinder  switch to .eh_frame) Daniel Mentz <danielmentz@google.com> - 2016-09-26 21:00 +0200

csiph-web