Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488933
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | arvind Yadav <arvind.yadav.cs@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc |
| Date | Thu, 22 Sep 2016 16:30:01 +0200 |
| Message-ID | <skdaF-7wd-15@gated-at.bofh.it> (permalink) |
| References | <skcRj-7nx-1@gated-at.bofh.it> <skd0Z-7t0-5@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=1qX1Y0KMhLM6XaRZMQ9vhXrUfMuV2sIo8D8inj25Ai4=; b=SLIuSqTm/oPzijLAanPh08VSI6dXnykn8UJs+U/6r/xp86tK06EwCk6vypdTmLRX3C rMQ0YJyFouxheg7XnmLLLMV9iPmPlhiwmX1GWWU4XXnDH/au6cLNk9rFBron+PMxkTy+ SSPn52acpTOdr4aw1QZtVjY88cJosAfqQb/WdB06jdYeb936MazEBG1LNV52WsV09vKj T3QLh/u5E99xxkSKwWVKUgW75jctGcOTg9sPtekUZOfpOhY4PC5Q+dK3JYab/RW/L+h6 YUXVWD+euYhiIm2ZNRNyyGHcB2QlYBPH8lJAgL65PpfMoh+2rEK3RmuVss7IN6+zJFf9 94gg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=1qX1Y0KMhLM6XaRZMQ9vhXrUfMuV2sIo8D8inj25Ai4=; b=IpJl/0ICohAKVt1q538T6tfoItJLgnLrZwX915u76UFVoUoWP1WqR8mBW9WF4IX55x vRQnwNkno9f63Fz90eglaGUx4IzYIRaC+n+6npf9Ds5cqdtLekxVbNBreCw2WYsJe+PD sULSTciFLv9kIKgoHK9+afG2yKTjQQlKXcCZGh70QAZCzLnHl3lJA0iWNAbWl5+1Fq4b 3tLC2Y6vIyskQ40aPN75vJORMqNjk+Or6nwuwl2Ly5ifkFhsmv0f1AxRbBP8Tb2GUzFR PSvxvw/5FOYmwAxC+SFcz5NcdEkhV67RqjUQ3Mk3iLv+fgqATbUTl4c3Z+OgfJyUu9Nr hfig== |
| X-Gm-Message-State | AE9vXwOXWEkE5niZjDlgP3Not1AC0eSDtGn6LSMaBYQ7XClAnNhaFtTCrOR2j2IiM6zNRQ== |
| X-Received | by 10.98.73.202 with SMTP id r71mr3768794pfi.36.1474554512461; Thu, 22 Sep 2016 07:28:32 -0700 (PDT) |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252; format=flowed |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 33 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | daniel.lezcano@linaro.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 22 Sep 2016 19:58:28 +0530 |
| X-Original-Message-ID | <2758043c-44a8-2217-3e3c-28e16b503c16@gmail.com> |
| X-Original-References | <1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com> <alpine.DEB.2.20.1609221608490.5599@nanos> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1488933 |
Show key headers only | View raw
I have changed subject as per your review comment.
thanks,
-Arvind
On Thursday 22 September 2016 07:46 PM, Thomas Gleixner wrote:
> On Thu, 22 Sep 2016, Arvind Yadav wrote:
>
>> Subject: clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc
> These subject lines are useless and way too long. A patch subject should
> describe the nature of the patch and not elaborate what the patch is doing
> technically.
>
> clocksrouce/timer-imz-gpt: Prevent resource leaks in error path
>
> would be a proper subject line which makes it entirely clear what this
> patch is about.
>
> From your subject line I have to read the patch itself to figure that
> out. It's completely irrelevant whether that resource is a mapping or
> allocated memory. The point is that the error path leaks resource(s).
>
> See Documentation/SubmittingPatches. There you'll find a lengthy
> explanation about changelogs and summary lines in particular.
>
> Thanks,
>
> tglx
>
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:10 +0200
Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc Thomas Gleixner <tglx@linutronix.de> - 2016-09-22 16:20 +0200
Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:30 +0200
Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc Thomas Gleixner <tglx@linutronix.de> - 2016-09-22 16:40 +0200
Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:50 +0200
csiph-web