Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488926

Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc
Date 2016-09-22 16:20 +0200
Message-ID <skd0Z-7t0-5@gated-at.bofh.it> (permalink)
References <skcRj-7nx-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, 22 Sep 2016, Arvind Yadav wrote:

> Subject: clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc

These subject lines are useless and way too long. A patch subject should
describe the nature of the patch and not elaborate what the patch is doing
technically.

   clocksrouce/timer-imz-gpt: Prevent resource leaks in error path

would be a proper subject line which makes it entirely clear what this
patch is about.

From your subject line I have to read the patch itself to figure that
out. It's completely irrelevant whether that resource is a mapping or
allocated memory. The point is that the error path leaks resource(s).

See Documentation/SubmittingPatches. There you'll find a lengthy
explanation about changelogs and summary lines in particular.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:10 +0200
  Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained  by of_iomap and kzalloc Thomas Gleixner <tglx@linutronix.de> - 2016-09-22 16:20 +0200
    Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region  obtained by of_iomap and kzalloc arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:30 +0200
      Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained  by of_iomap and kzalloc Thomas Gleixner <tglx@linutronix.de> - 2016-09-22 16:40 +0200
        Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region  obtained by of_iomap and kzalloc arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:50 +0200

csiph-web