Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"
Date	2016-09-24 19:10 +0200
Message-ID	<skYCC-3JI-9@gated-at.bofh.it> (permalink)
References	<skVv3-1Az-13@gated-at.bofh.it> <skVv3-1Az-19@gated-at.bofh.it> <skYjg-3o6-27@gated-at.bofh.it> <skYsV-3rl-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2016-09-24 at 18:55 +0200, SF Markus Elfring wrote:
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > Why did you split it off from the patch where you attempt to use it?
> I chose a special patch granularity once again.
> > What good does this change do on its own?
> I find that it is a preparation. - If this addition could not be accepted,
> the following update step would also be discussed under an other perspective,
> wouldn't it?

It's purposeless, creates unnecessary patches to review
and generally wastes other people's time.

Please don't purposefully waste other people's time.
It makes your patch proposals _less_ likely to be applied.

Thread

[PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module  "joydump" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 15:50 +0200
  Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module  "joydump" Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-24 18:50 +0200
    Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module  "joydump" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 19:00 +0200
      Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module  "joydump" Joe Perches <joe@perches.com> - 2016-09-24 19:10 +0200
        Re: Input-gameport: Add the macro "pr_fmt" for module "joydump" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 19:50 +0200
          Re: Input-gameport: Add the macro "pr_fmt" for module "joydump" Joe Perches <joe@perches.com> - 2016-09-24 20:10 +0200
            Re: Input-gameport: Add the macro "pr_fmt" for module "joydump" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 20:50 +0200

csiph-web