[PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Baoyou Xie <baoyou.xie@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up
Date	Sat, 24 Sep 2016 07:30:02 +0200
Message-ID	<skNHc-5m9-17@gated-at.bofh.it> (permalink)
X-Original-To	isdn@linux-pingi.de
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=PP5O48jbvNwfwvfg5ReLIZCrAoT43Ez64YcAPmN4WMo=; b=Vyvpt0xwqqnlBAitBgWSu+VMhxCF27kk8OdevPsGBMl4qwfRqhAMDRQ0vglmTc5zkW Qtz0JcgQgJYAvnXsrdgUOq8mpFVdR15bTcxciO0gUSBbeJdUqMs27naM0i+j0nBBH6h1 GONCsnq60FnlThz1Zf4QrPBYBn9Oqa6+IkeGQ=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PP5O48jbvNwfwvfg5ReLIZCrAoT43Ez64YcAPmN4WMo=; b=AXIOcv8Y3HKfYZyDOv1ZhvCYTKE/qM2PqTfizMjYUIBsp1Ojw5rOeGcvwD/dgm/u+A tMb2cag7tiR1FIH/GHUUiE63WToxlmZFuTW/h+Q2LlLHm5uRF+gYpe/iD7AVd6Ld7+3M VeuhqC+SGM/0D7+yfoBc1uF/hyZTXYDceIN3YW2/gpa3ryFQ3sKxbwOw0hKBXZLPsw/W XrZxDKo0CflH20I7hz8WNB+MV+1aQ3FzDwMemonoC7iZi9bHYwyb4/rsi08y88OHaLbI T27bxZdQQHbgw7PuPxiU48CNVE8cVIDEhg2LgsHI9PMyGQrsf6XUmdcAONDb4eHJgDp1 anTQ==
X-Gm-Message-State	AE9vXwN2cepuQNsqEdSrgEBe17t2s5aHKMxfcDCTntPwu/4kz3VmoiC5OXQlBi98UC0+PVyJ
X-Received	by 10.66.254.170 with SMTP id aj10mr18948332pad.124.1474694677919; Fri, 23 Sep 2016 22:24:37 -0700 (PDT)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn
X-Original-Date	Sat, 24 Sep 2016 13:24:22 +0800
X-Original-Message-ID	<1474694662-7527-1-git-send-email-baoyou.xie@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1490557

Show key headers only | View raw

We get 1 warning when building kernel with W=1:
drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes]

In fact, this function is declared in
drivers/isdn/hisax/elsa_ser.c, but should be
declard in a header file, thus can be recognized in other file.

So this patch moves the declaration into drivers/isdn/hisax/hscx.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/isdn/hisax/elsa_ser.c | 2 +-
 drivers/isdn/hisax/hscx.h     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/isdn/hisax/elsa_ser.c b/drivers/isdn/hisax/elsa_ser.c
index a2a358c..34ccc18 100644
--- a/drivers/isdn/hisax/elsa_ser.c
+++ b/drivers/isdn/hisax/elsa_ser.c
@@ -10,6 +10,7 @@
 #include <linux/serial.h>
 #include <linux/serial_reg.h>
 #include <linux/slab.h>
+#include "hscx.h"
 
 #define MAX_MODEM_BUF	256
 #define WAKEUP_CHARS	(MAX_MODEM_BUF / 2)
@@ -419,7 +420,6 @@ static void rs_interrupt_elsa(struct IsdnCardState *cs)
 #endif
 }
 
-extern int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs);
 extern void modehscx(struct BCState *bcs, int mode, int bc);
 extern void hscx_l2l1(struct PStack *st, int pr, void *arg);
 
diff --git a/drivers/isdn/hisax/hscx.h b/drivers/isdn/hisax/hscx.h
index 1148b4b..fa7bf16 100644
--- a/drivers/isdn/hisax/hscx.h
+++ b/drivers/isdn/hisax/hscx.h
@@ -39,3 +39,4 @@ extern void modehscx(struct BCState *bcs, int mode, int bc);
 extern void clear_pending_hscx_ints(struct IsdnCardState *cs);
 extern void inithscx(struct IsdnCardState *cs);
 extern void inithscxisac(struct IsdnCardState *cs, int part);
+int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 07:30 +0200
  Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Arnd Bergmann <arnd@arndb.de> - 2016-09-24 11:00 +0200
  Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-24 16:20 +0200

csiph-web