Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up
Date	2016-09-24 16:20 +0200
Message-ID	<skVY5-23O-5@gated-at.bofh.it> (permalink)
References	<skNHc-5m9-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello.

On 9/24/2016 8:24 AM, Baoyou Xie wrote:

> We get 1 warning when building kernel with W=1:
> drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes]
>
> In fact, this function is declared in
> drivers/isdn/hisax/elsa_ser.c, but should be
> declard in a header file, thus can be recognized in other file.

    Declared.

> So this patch moves the declaration into drivers/isdn/hisax/hscx.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 07:30 +0200
  Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Arnd Bergmann <arnd@arndb.de> - 2016-09-24 11:00 +0200
  Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-24 16:20 +0200

csiph-web